Bug 281729 - devel/libclc: add support for llvm19
Summary: devel/libclc: add support for llvm19
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-x11 (Nobody)
URL:
Keywords:
Depends on:
Blocks: 282316
  Show dependency tree / graph
 
Reported: 2024-09-26 15:30 UTC by Jordan Ostreff
Modified: 2024-11-01 18:21 UTC (History)
4 users (show)

See Also:
manu: maintainer-feedback+

Attachments
Add support for llvm19 (1.59 KB, patch)
2024-10-25 05:15 UTC, Jung-uk Kim 		no flags Details | Diff
Add support for llvm19 (8.00 KB, patch)
2024-10-31 02:25 UTC, Jung-uk Kim 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jordan Ostreff 2024-09-26 15:30:39 UTC 
diff --git a/devel/libclc/Makefile b/devel/libclc/Makefile
index 0ddee4d60809..ffa3ea6fb0d5 100644
--- a/devel/libclc/Makefile
+++ b/devel/libclc/Makefile
@@ -1,5 +1,6 @@
 PORTNAME=      libclc
 DISTVERSION=   ${DISTVERSION_${FLAVOR}}
+DISTVERSION_llvm19=    19.1.0
 DISTVERSION_llvm18=    18.1.8
 DISTVERSION_llvm17=    17.0.6
 DISTVERSION_llvm16=    16.0.6
@@ -21,7 +22,7 @@ LICENSE_PERMS=        dist-mirror dist-sell pkg-mirror pkg-sell auto-accept
 BUILD_DEPENDS= spirv-llvm-translator-${FLAVOR}>0:devel/spirv-llvm-translator@${FLAVOR} \
                libedit>=0:devel/libedit
 
-FLAVORS=       ${15 16 17 18:L:S/^/llvm/}
+FLAVORS=       ${15 16 17 18 19:L:S/^/llvm/}
 
 USES=          cmake compiler:c++11-lib llvm:${FLAVOR:S/llvm//},build python:build tar:xz
 USE_LDCONFIG=  ${PREFIX}/${FLAVOR}/lib



then FLAVOR=llvm19 make makesum
Comment 1 Jordan Ostreff 2024-09-26 15:34:17 UTC 
I forgot to explain - there is missing FLAVOR=llvm19 for this port. I hav made needed changes for my local posts tree copy, and port was build fine. There are probably some additional places to be changed, because some cosmetic messages are not fine but ...


===>   Registering installation for libclc-llvm19-19.1.0
Installing libclc-llvm19-19.1.0...

===>>> Deleting stale distfile: libclc-15.0.7.src.tar.xz
===>>> Installation of devel/libclc@llvm19 (** libclc-llvm15-15.0.7 ** ) complete
Comment 2 Jung-uk Kim freebsd_committer freebsd_triage 2024-10-25 05:15:02 UTC 
Created attachment 254501 [details]
Add support for llvm19
Comment 3 Jung-uk Kim freebsd_committer freebsd_triage 2024-10-25 05:19:27 UTC 
(In reply to Jordan Ostreff from comment #1)
Note pkg-plist is incomplete if you just add llvm flavor because 1) there are two new files for llvm19 and 2) files added for llvm18 must be installed for llvm19 as well.
Comment 4 Emmanuel Vadot freebsd_committer freebsd_triage 2024-10-25 05:59:11 UTC 
(In reply to Jung-uk Kim from comment #2)

Thanks,
Comment 5 Jung-uk Kim freebsd_committer freebsd_triage 2024-10-31 02:25:26 UTC 
Created attachment 254784 [details]
Add support for llvm19

The patch is updated to 19.1.3.  While I am here, pkg-plist is sorted.
Comment 6 Emmanuel Vadot freebsd_committer freebsd_triage 2024-10-31 10:29:16 UTC 
LGTM
Comment 7 commit-hook freebsd_committer freebsd_triage 2024-10-31 21:27:15 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bccbfd11abf725b7cafab9dc83058cec224fce3f

commit bccbfd11abf725b7cafab9dc83058cec224fce3f
Author:     Jung-uk Kim <jkim@FreeBSD.org>
AuthorDate: 2024-10-31 21:22:25 +0000
Commit:     Jung-uk Kim <jkim@FreeBSD.org>
CommitDate: 2024-10-31 21:22:25 +0000

    devel/libclc: Add support for clang 19

    Sort pkg-plist while I am here.

    Reviewed by:    manu
    PR:             281729

 devel/libclc/Makefile              |  12 +++--
 devel/libclc/distinfo.llvm19 (new) |   3 ++
 devel/libclc/pkg-plist             | 100 +++++++++++++++++++------------------
 3 files changed, 63 insertions(+), 52 deletions(-)