Created attachment 253845 [details] [PATCH] net/krakend-ce: update 2.7.1 → 2.7.2
Hi Älven, could you please add TEST_TARGET=test? https://github.com/krakend/krakend-ce/blob/master/Makefile#L66 The 'make test' fails, could you please check it? ===> Testing ./... ? github.com/krakendio/krakend-ce/v2 [no test files] ? github.com/krakendio/krakend-ce/v2/cmd/krakend-ce [no test files] ? github.com/krakendio/krakend-ce/v2/cmd/krakend-integration [no test files] === RUN TestNewIntegration integration_test.go:10: fork/exec .././krakend: no such file or directory --- FAIL: TestNewIntegration (0.00s) === RUN ExampleNewIntegration --- FAIL: ExampleNewIntegration (0.00s) got: fork/exec .././krakend: no such file or directory want: signal: killed FAIL FAIL github.com/krakendio/krakend-ce/v2/tests 0.008s FAIL *** Error code 1 Thanks!
Hi, Thank you for the advice, sure I'll follow it. I usually tested ports via `poudriere testport` and expected it to do all the tests. As it's not always true, I'll check what you asked me about. (Not so sure I could be able to fix it though). Thanks!
Comment on attachment 253845 [details] [PATCH] net/krakend-ce: update 2.7.1 → 2.7.2 Not passed tests. I'm to rework it.
(In reply to Älven from comment #2) The TEST_TARGET calls the actual port's test - so this isn't poudriere's checks/tests. If you check the source (https://github.com/krakend/krakend-ce) can find a "test" directory. It contains small checks which test the program works well or not (the 'test' target can you find at https://github.com/krakend/krakend-ce/blob/master/Makefile#L66).
Created attachment 254033 [details] [PATCH] net/krakend-ce: update 2.7.1 → 2.7.2 Thank you for the explanation and sorry for the delay. I've added TEST_TARGET=test and patch for it to work. All seems OK now. Test, please. On poudriere: I was expecting TEST_TARGET to always be 'test' by default and `poudriere testport` to run 'make test'. And both weren't as I expected :) Hope we'll have the second case working when [0] will be fixed. Regards, Älven [0] https://github.com/freebsd/poudriere/pull/355
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=858917c7c36f2926c3c935945f8e1c38a8a80941 commit 858917c7c36f2926c3c935945f8e1c38a8a80941 Author: Älven <alster@vinterdalen.se> AuthorDate: 2024-10-07 07:33:30 +0000 Commit: Zsolt Udvari <uzsolt@FreeBSD.org> CommitDate: 2024-10-07 07:37:01 +0000 net/krakend-ce: Update to 2.7.2 Add TEST_TARGET and patch with fix of default path to the krakend bin. Use go 1.23. Changelog: https://github.com/krakend/krakend-ce/releases/tag/v2.7.2 PR: 281739 Approved by: submitter is maintainer net/krakend-ce/Makefile | 13 +++++++------ net/krakend-ce/distinfo | 10 +++++----- net/krakend-ce/files/patch-tests_integration.go (new) | 11 +++++++++++ 3 files changed, 23 insertions(+), 11 deletions(-)
Committed, thanks!