Created attachment 253957 [details] Move textproc/fop to DOCS_BUILD_DEPENDS The PostgreSQL 17 ports have had BUILD_DEPENDS of textproc/fop added as a blanket dependency, but it's apparently only necessary for building PDF documentation of the software. (https://www.postgresql.org/docs/current/docguide-build.html) It should not be a hard requirement when DOCS are not built. Moreover, textproc/fop requires OpenJDK to be present, and now building anything related to even postgresql17-client pulls in OpenJDK 18, 19, 20, and 21 (if specified, and I have). And extra. This means too much wasted CPU time. I propose removing textproc/fop from the blanket BUILD_DEPENDS and moving it to DOCS_BUILD_DEPENDS as seen in the attachment.
I fail to see why fop is required at all. The Makefile never builds the PDF and no plist contains a PDF. What am I missing here?
(In reply to Michael Osipov from comment #1) I did not go digging to be honest. It sure does seem that you're right.
Thanks! I moved the dependency to the postgresql17-docs port since that is where it is used.
(In reply to Palle Girgensohn from comment #3) I believe you can boldly drop this one: https://github.com/freebsd/freebsd-ports/blob/7cddc85218bdcd3df11fa8952cdcad49847f08d6/databases/postgresql17-docs/Makefile#L21 You don't build the PDF and the build instructions say that FOP is used for PDF only. You'd remove a huge dependency tree here.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=e0440ff539a4ade550cd21786df92190d3fb3102 commit e0440ff539a4ade550cd21786df92190d3fb3102 Author: Palle Girgensohn <girgen@FreeBSD.org> AuthorDate: 2024-10-08 14:19:35 +0000 Commit: Palle Girgensohn <girgen@FreeBSD.org> CommitDate: 2024-10-08 15:16:35 +0000 databases/postgresql17: Remove build dependency on fop It is only required when building the postgresql17-docs port. PR: 281814 databases/postgresql17-client/Makefile | 1 - databases/postgresql17-server/Makefile | 1 - 2 files changed, 2 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=cf1a12c828566036fa220e87e539394475be69cc commit cf1a12c828566036fa220e87e539394475be69cc Author: Palle Girgensohn <girgen@FreeBSD.org> AuthorDate: 2024-10-09 08:31:22 +0000 Commit: Palle Girgensohn <girgen@FreeBSD.org> CommitDate: 2024-10-09 08:31:59 +0000 databases/postgresql17-docs: Remove build dependency on fop It is only required when building PDF, which we don't. PR: 281814 databases/postgresql17-docs/Makefile | 1 - 1 file changed, 1 deletion(-)