X11-only users may have OPTIONS_UNSET+=WAYLAND in /etc/make.conf. x11-toolkits/gtk-layer-shell requires WAYLAND in x11-toolkits/gtk30, so consumers like x11/xfce4-whiskermenu-plugin cannot use a different option name without introducing breakage. The ports/ framework doesn't support overriding options in dependencies, and X11-only users likely don't want Wayland dependencies silently re-enabled. gtk-layer-shell is supported by wlroots, KDE, Mir, Cosmic. Exceptions are GNOME (uses shell extensions instead) and Weston (uses plugins instead). Apps supporting more than one approach are very unlikely, so it's should be fine to use generic port option name like WAYLAND.
Hi, I see no problem with such a change, so with xfce hat I approve. It is only an option name change, as far as I can see. Please keep the default as is (on?) and maybe add an UPDATING entry to keep users informed. Can you perform this change yourself?
BTW at present there is no real wayland support in XFCE, but something is coming with the next release, although I have made no tests so I don't know how long it will take to make it properly available in the ports tree.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=9c49c355b92317171a50ff9efb828c435b7cf166 commit 9c49c355b92317171a50ff9efb828c435b7cf166 Author: Jan Beich <jbeich@FreeBSD.org> AuthorDate: 2024-10-07 13:45:44 +0000 Commit: Jan Beich <jbeich@FreeBSD.org> CommitDate: 2024-10-07 13:58:59 +0000 x11/xfce4-whiskermenu-plugin: rename GTK_LAYER_SHELL to WAYLAND Allow X11-only users to globally disable Wayland dependencies via OPTIONS_UNSET+=WAYLAND in make.conf(5). Besides, gtk-layer-shell will fail to build unless gtk3 is built with WAYLAND enabled. PR: 281846 Approved by: madpilot x11/xfce4-whiskermenu-plugin/Makefile | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=fb43c5e9543b7a832f6a69feda2344a455d2c757 commit fb43c5e9543b7a832f6a69feda2344a455d2c757 Author: Jan Beich <jbeich@FreeBSD.org> AuthorDate: 2024-10-07 14:00:48 +0000 Commit: Jan Beich <jbeich@FreeBSD.org> CommitDate: 2024-10-07 14:02:38 +0000 x11/xfce4-whiskermenu-plugin: sort options after 9c49c355b923 PR: 281846 x11/xfce4-whiskermenu-plugin/Makefile | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
(In reply to Guido Falsi from comment #1) > maybe add an UPDATING entry to keep users informed. Very unlikely for a user to disable GTK_LAYER_SHELL but not WAYLAND. Lots of ports have WAYLAND option. Besides, manual build should re-trigger "make config" due to a new option.