Bug 281873 - net/rinetd: Downgrade to 0.62 until upstream fixes performance issues
Summary: net/rinetd: Downgrade to 0.62 until upstream fixes performance issues
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Michael Gmelin
URL: https://github.com/samhocevar/rinetd/...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-05 17:23 UTC by Michael Gmelin
Modified: 2024-12-09 15:04 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (garga)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Gmelin freebsd_committer freebsd_triage 2024-10-05 17:23:34 UTC 
In bug #274331 rinetd was updated to the new upstream and its latest release. 

Unfortunately this version has massive performance issues on FreeBSD (in my use case transfers got almost 500 times slower).

This has been reported upstream almost a year ago[0], but no solution so far.

Therefore I would suggest to bump PORTEPOCH and revert to the last known good version (0.62_4) until this has been resolved. In its current state updating the port causes causes breakage (depending on what it is used for of course).

[0]https://github.com/samhocevar/rinetd/issues/42
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2024-10-05 20:55:18 UTC 
Not saying it's a "fix" but since upstream development seems to have slowed down one alternative is to use socat (net/socat) to achieve the same result. I also just for fun made a quick port of rustocat (https://git.hibas.dev/ops/rustocat) that seems to perform very well.

https://projects.pyret.net/files/freebsd-patches/rustocat-dev-v2.patch
Comment 2 Renato Botelho freebsd_committer freebsd_triage 2024-10-07 12:33:58 UTC 
Michael,

I'm not using rinetd for a long time so if you want to takeover maintainership, you got my approval.  If you just want to make downgrade it to previous version, go ahead and you have my implicit approval.
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2024-12-08 21:35:05 UTC 
Should we sunset this port as there's no progress for months and upstream no longer seems to be active?
Comment 4 Renato Botelho freebsd_committer freebsd_triage 2024-12-09 12:27:45 UTC 
(In reply to Daniel Engberg from comment #3)
I would not object
Comment 5 Michael Gmelin freebsd_committer freebsd_triage 2024-12-09 13:49:53 UTC 
(In reply to Renato Botelho from comment #4)

Hi Renato, I'll take maintainership and the bug from you and first downgrade, later fix the new version.
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-12-09 15:03:06 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9e46f71b468dd8d6446d8960b818afbac5416d62

commit 9e46f71b468dd8d6446d8960b818afbac5416d62
Author:     Michael Gmelin <grembo@FreeBSD.org>
AuthorDate: 2024-12-09 13:57:13 +0000
Commit:     Michael Gmelin <grembo@FreeBSD.org>
CommitDate: 2024-12-09 15:01:57 +0000

    net/rinetd: Downgrade to 0.62, take maintainership

    This fixes massive performance issues, but also loses IPv6
    support.

    Updates will come back, once regressions have been corrected.

    PR:             281873

 net/rinetd/Makefile                           |  22 ++-
 net/rinetd/distinfo                           |   6 +-
 net/rinetd/files/patch-Makefile (new)         |  22 +++
 net/rinetd/files/patch-rinetd.c (new)         | 210 ++++++++++++++++++++++++++
 net/rinetd/files/patch-src_Makefile.am (gone) |  11 --
 net/rinetd/files/patch-src_rinetd.c (gone)    |  11 --
 net/rinetd/pkg-plist (gone)                   |   3 -
 7 files changed, 244 insertions(+), 41 deletions(-)
Comment 7 Michael Gmelin freebsd_committer freebsd_triage 2024-12-09 15:04:25 UTC 
(In reply to Daniel Engberg from comment #1)

Rustocat looks quite interesting, I might create a port based on your work.