Bug 281876 - www/newsboat: Update 2.36 → 2.36.1
Summary: www/newsboat: Update 2.36 → 2.36.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-05 20:13 UTC by Marko Turk
Modified: 2024-12-05 10:54 UTC (History)
1 user (show)

See Also:
mt-bugs: maintainer-feedback+


Attachments
patch (1.38 KB, patch)
2024-10-05 20:13 UTC, Marko Turk
mt-bugs: maintainer-approval+
Details | Diff
patch (1.32 KB, patch)
2024-10-07 20:30 UTC, Marko Turk
mt-bugs: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marko Turk 2024-10-05 20:13:40 UTC
Created attachment 254028 [details]
patch

Hi,

Sending a patch to update newsboat to 2.36.1 which includes a fix where newsboat ignores 304 Not Modified.

Changelog:
https://github.com/newsboat/newsboat/blob/master/CHANGELOG.md#2361---2024-09-22

Marko
Comment 1 Marko Turk 2024-10-05 20:14:57 UTC
I also added STRIP_CMD as stage-qa suggested.

Marko
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2024-10-05 22:42:03 UTC
To reduce the IO during build, I suggest doing the following in post-install:
${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/podboat ${STAGEDIR}${PREFIX}/bin/newsboat
or even:
${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/*
Comment 3 Marko Turk 2024-10-07 19:04:06 UTC
(In reply to Vladimir Druzenko from comment #2)

I'm sorry, I don't understand. I already added strip cmd to post-install, is there something missing in my patch?

Marko
Comment 4 Vladimir Druzenko freebsd_committer freebsd_triage 2024-10-07 19:41:27 UTC
(In reply to Marko Turk from comment #3)
In your patch strip run 2 times (for each file). My suggestion is to run strip one time for all files.
Comment 5 Marko Turk 2024-10-07 20:29:37 UTC
(In reply to Vladimir Druzenko from comment #4)

Oh, okay. Attaching a new patch.

Thanks.

Marko
Comment 6 Marko Turk 2024-10-07 20:30:12 UTC
Created attachment 254080 [details]
patch
Comment 7 commit-hook freebsd_committer freebsd_triage 2024-10-07 21:49:19 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ec8699ad9928583229757c9dbc57faca21b6cfb0

commit ec8699ad9928583229757c9dbc57faca21b6cfb0
Author:     Marko Turk <mt-bugs@markoturk.info>
AuthorDate: 2024-10-07 21:45:20 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-10-07 21:45:20 +0000

    www/newsboat: Update 2.36 → 2.36.1

    Changelog:
    https://github.com/newsboat/newsboat/blob/r2.36.1/CHANGELOG.md

    Add STRIP_CMD as stage-qa suggested.

    PR:     281876

 www/newsboat/Makefile | 6 ++++--
 www/newsboat/distinfo | 6 +++---
 2 files changed, 7 insertions(+), 5 deletions(-)
Comment 8 Vladimir Druzenko freebsd_committer freebsd_triage 2024-10-07 21:50:15 UTC
Committed, thanks.

2.37 released: https://github.com/newsboat/newsboat/releases/tag/r2.37
Do you plan to update to 2.37?
Comment 9 Marko Turk 2024-10-08 10:21:58 UTC
(In reply to Vladimir Druzenko from comment #8)

Yes, I plan to update to 2.37 in a few days probably.

Marko
Comment 10 Vladimir Druzenko freebsd_committer freebsd_triage 2024-10-08 10:41:55 UTC
(In reply to Marko Turk from comment #9)
If you plan to create new PR then close this with status FIXED.
Or attach patch here.
Comment 11 commit-hook freebsd_committer freebsd_triage 2024-12-05 10:54:29 UTC
A commit in branch 2024Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bf5664b185d8da437f02d29de30204b9bd97f25d

commit bf5664b185d8da437f02d29de30204b9bd97f25d
Author:     Marko Turk <mt-bugs@markoturk.info>
AuthorDate: 2024-10-07 21:45:20 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2024-12-05 10:36:12 +0000

    www/newsboat: Update 2.36 → 2.36.1

    Changelog:
    https://github.com/newsboat/newsboat/blob/r2.36.1/CHANGELOG.md

    Add STRIP_CMD as stage-qa suggested.

    PR:     281876
    (cherry picked from commit ec8699ad9928583229757c9dbc57faca21b6cfb0)

 www/newsboat/Makefile | 6 ++++--
 www/newsboat/distinfo | 6 +++---
 2 files changed, 7 insertions(+), 5 deletions(-)