Bug 281881 - games/sokoban: Install xsokoban's screens
Summary: games/sokoban: Install xsokoban's screens
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-06 01:10 UTC by mew14930xvi
Modified: 2024-11-14 08:57 UTC (History)
1 user (show)

See Also:

Attachments
Install xsokoban's screens. (2.89 KB, patch)
2024-10-06 01:10 UTC, mew14930xvi 		no flags Details | Diff
install xsokoban's screens (2.98 KB, patch)
2024-10-08 23:02 UTC, mew14930xvi 		no flags Details | Diff
Install xsokoban's screens (4.13 KB, patch)
2024-11-13 04:51 UTC, mew14930xvi 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mew14930xvi 2024-10-06 01:10:18 UTC 
Created attachment 254031 [details]
Install xsokoban's screens.
Comment 1 mew14930xvi 2024-10-08 23:02:10 UTC 
Created attachment 254101 [details]
install xsokoban's screens

take maintainership.
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2024-11-12 13:48:30 UTC 
The whole “reach across to another port and grab its distfile” thing is not a good idea and tends to be somewhat fragile.  And I'm sure it won't build in Poudriere as is.

Instead, add the xsokoban distfile as a distfile to this port and grab the screens from there.

You could also add xsokoban as a RUN_DEPENDS and patch the program so it looks in ${LOCALBASE}/lib/X11/xsokoban/screens for the xsokoban screens.

Please revisit this patch and adjust it as indicated.
Comment 3 mew14930xvi 2024-11-12 14:32:28 UTC 
As far as I have tried, I can build with poudriere.
A similar japanese/multiskkserv could also be built.
multiskkserv is a port that was once removed and resurrected.
Comment 4 mew14930xvi 2024-11-13 04:51:13 UTC 
Created attachment 255131 [details]
Install xsokoban's screens
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2024-11-13 12:09:35 UTC 
Thank you for the improved patch.
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-11-14 08:45:19 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2b9e7c186a2ecaa18da974741cd9404ba1f4fa61

commit 2b9e7c186a2ecaa18da974741cd9404ba1f4fa61
Author:     mew14930xvi <mew14930xvi@inbox.lv>
AuthorDate: 2024-11-13 12:09:00 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2024-11-14 08:43:28 +0000

    games/sokoban: install xsokoban's screens

     - maintainership goes to submitter

    PR:             281881

 games/sokoban/Makefile              | 24 ++++++++++++----------
 games/sokoban/distinfo              |  3 +++
 games/sokoban/files/patch-sokoban.h |  9 +++++++++
 games/sokoban/pkg-descr             |  1 +
 games/sokoban/pkg-plist             | 40 +++++++++++++++++++++++++++++++++++++
 5 files changed, 66 insertions(+), 11 deletions(-)
Comment 7 Robert Clausecker freebsd_committer freebsd_triage 2024-11-14 08:57:15 UTC 
Thank you for your contribution.