Bug 281912 - finance/ledger: Fix build with boost 1.85.0
Summary: finance/ledger: Fix build with boost 1.85.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Zsolt Udvari
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-07 06:21 UTC by Chad Jacob Milios
Modified: 2024-11-03 19:24 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (woodycarey)


Attachments
git -C /usr/ports diff finance/ledger (931 bytes, patch)
2024-10-07 06:21 UTC, Chad Jacob Milios
milios: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chad Jacob Milios 2024-10-07 06:21:08 UTC
Created attachment 254068 [details]
git -C /usr/ports diff finance/ledger

i think Boost rolled convenience.hpp into operations.hpp, if i understood the issue correctly. did not notify upstream; i'm sure they'll figure it out eventually
Comment 1 Edward.Sanford.Sutton, III 2024-10-20 19:35:29 UTC
Upstream handled this under https://github.com/ledger/ledger/pull/2337 last May by removing the include so a patch would be appropriate until a new ledger version hits the ports tree.
Comment 2 Chad Jacob Milios 2024-10-21 03:21:53 UTC
(In reply to Edward.Sanford.Sutton, III from comment #1)

Thank you for digging that up.

i was about to reformulate the PR-attached patch to instead use PATCH_SITES and PATCHFILES, pointing to the identical patch via github commit you just referenced, rather than a files/patch-foo ...but... i then realized i'd initially patched a patch, a pre-existing FreeBSD specific files/patch-foo upon the same WRKSRC target file.

btw fyi, the ports version still equals the latest dist release file/tag version

so rather than confuse the matter into two steps i think the already attached Problem Report patch upon $PORTSDIR/finance/ledger/files/patch-system.hh.in is golden so...

...TLDR:
its identical accepted Pull Request upstream pretty well proves anyone can commit this at any time; thank you to everyone
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-11-03 19:20:53 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bf25239a296dbd6077b90211d7605b45a3b534b8

commit bf25239a296dbd6077b90211d7605b45a3b534b8
Author:     Chad Jacob Milios <milios@ccsys.com>
AuthorDate: 2024-11-03 19:13:12 +0000
Commit:     Zsolt Udvari <uzsolt@FreeBSD.org>
CommitDate: 2024-11-03 19:13:12 +0000

    finance/ledger: Fix build with boost 1.85.0

    While I'm here pet portfmt.

    PR:             281912
    Approved by:    portmgr (blanket)
    MFH:            2024Q4

 finance/ledger/Makefile                 | 15 ++++++++-------
 finance/ledger/files/patch-system.hh.in | 12 ++++++++++--
 2 files changed, 18 insertions(+), 9 deletions(-)
Comment 4 Zsolt Udvari freebsd_committer freebsd_triage 2024-11-03 19:24:54 UTC
Committed, thanks!
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-11-03 19:24:55 UTC
A commit in branch 2024Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4b9c10b813c16813a005e462791b6cf5fb6b2935

commit 4b9c10b813c16813a005e462791b6cf5fb6b2935
Author:     Chad Jacob Milios <milios@ccsys.com>
AuthorDate: 2024-11-03 19:13:12 +0000
Commit:     Zsolt Udvari <uzsolt@FreeBSD.org>
CommitDate: 2024-11-03 19:23:22 +0000

    finance/ledger: Fix build with boost 1.85.0

    While I'm here pet portfmt.

    PR:             281912
    Approved by:    portmgr (blanket)
    MFH:            2024Q4

    (cherry picked from commit bf25239a296dbd6077b90211d7605b45a3b534b8)

 finance/ledger/Makefile                 | 15 ++++++++-------
 finance/ledger/files/patch-system.hh.in | 12 ++++++++++--
 2 files changed, 18 insertions(+), 9 deletions(-)