Bug 281926 - security/crowdsec: important but tricky update to 1.6.3-2
Summary: security/crowdsec: important but tricky update to 1.6.3-2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Philippe Audeoud
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-07 14:47 UTC by marco
Modified: 2024-10-08 07:11 UTC (History)
1 user (show)

See Also:


Attachments
patch for 1.6.3-2 (1.69 KB, patch)
2024-10-07 14:47 UTC, marco
marco: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description marco 2024-10-07 14:47:35 UTC
Created attachment 254075 [details]
patch for 1.6.3-2

Unfortunately, in the attempt to solve a process management issue, version 1.6.3 made things worse and it now kills the "sbin/daemon" process without giving it a chance to terminate crowdsec itself.

So when in 1.6.3-1 the command "service crowdsec stop" is run, it just hangs on wait_for_pids because the process was never sent a signal.

While this patch sends the correct signals directly, upgrading means having to terminate the crowdsec process by hand.

Has this situation ever occcured and is there a solution?

Thanks
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-10-08 07:06:22 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b4671758afd7a15a22d5e9dcdb25b61134d18316

commit b4671758afd7a15a22d5e9dcdb25b61134d18316
Author:     marco <marco@crowdsec.net>
AuthorDate: 2024-10-07 14:03:59 +0000
Commit:     Philippe Audeoud <jadawin@FreeBSD.org>
CommitDate: 2024-10-08 06:03:37 +0000

    security/crowdsec: v1.6.3_2 with improved process handling

    PR:             281926

 security/crowdsec/Makefile          | 2 +-
 security/crowdsec/files/crowdsec.in | 9 +++++++++
 2 files changed, 10 insertions(+), 1 deletion(-)
Comment 2 Philippe Audeoud freebsd_committer freebsd_triage 2024-10-08 07:11:03 UTC
Committed, thanks!