Bug 281980 - www/gitlab: update to 7.4.1_1 fails
Summary: www/gitlab: update to 7.4.1_1 fails
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Matthias Fechner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-09 22:45 UTC by gwright
Modified: 2024-10-10 07:14 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (mfechner)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description gwright 2024-10-09 22:45:00 UTC
When updating gitlab to 7.4.1_1, the process failed when running the database migration:

root@gitlab:~ # cd /usr/local/www/gitlab
root@gitlab:/usr/local/www/gitlab # su -l git -c "cd /usr/local/www/gitlab && rake db:migrate RAILS_ENV=production"
rake aborted!
NameError: uninitialized constant Aws::Plugins::GlobalConfiguration (NameError)

Aws::Plugins::GlobalConfiguration.add_identifier(:cloudformation)
            ^^^^^^^^^^^^^^^^^^^^^
/usr/local/www/gitlab/config/application.rb:18:in `<top (required)>'
<internal:/usr/local/lib/ruby/site_ruby/3.2/rubygems/core_ext/kernel_require.rb>:136:in `require'
<internal:/usr/local/lib/ruby/site_ruby/3.2/rubygems/core_ext/kernel_require.rb>:136:in `require'
/usr/local/www/gitlab/Rakefile:9:in `<top (required)>'
(See full trace by running task with --trace)
root@gitlab:/usr/local/www/gitlab #

The full trace:

root@gitlab:/usr/local/www/gitlab # su -l git -c "cd /usr/local/www/gitlab && rake --trace db:migrate RAILS_ENV=production"
rake aborted!
NameError: uninitialized constant Aws::Plugins::GlobalConfiguration (NameError)

Aws::Plugins::GlobalConfiguration.add_identifier(:cloudformation)
            ^^^^^^^^^^^^^^^^^^^^^
/usr/local/lib/ruby/gems/3.2/gems/aws-sdk-cloudformation-1.120.0/lib/aws-sdk-cloudformation.rb:14:in `<top (required)>'
/usr/local/lib/ruby/gems/3.2/gems/bundler-2.5.20/lib/bundler/runtime.rb:60:in `require'
/usr/local/lib/ruby/gems/3.2/gems/bundler-2.5.20/lib/bundler/runtime.rb:60:in `block (2 levels) in require'
/usr/local/lib/ruby/gems/3.2/gems/bundler-2.5.20/lib/bundler/runtime.rb:55:in `each'
/usr/local/lib/ruby/gems/3.2/gems/bundler-2.5.20/lib/bundler/runtime.rb:55:in `block in require'
/usr/local/lib/ruby/gems/3.2/gems/bundler-2.5.20/lib/bundler/runtime.rb:44:in `each'
/usr/local/lib/ruby/gems/3.2/gems/bundler-2.5.20/lib/bundler/runtime.rb:44:in `require'
/usr/local/lib/ruby/gems/3.2/gems/bundler-2.5.20/lib/bundler.rb:212:in `require'
/usr/local/www/gitlab/config/application.rb:18:in `<top (required)>'
<internal:/usr/local/lib/ruby/site_ruby/3.2/rubygems/core_ext/kernel_require.rb>:136:in `require'
<internal:/usr/local/lib/ruby/site_ruby/3.2/rubygems/core_ext/kernel_require.rb>:136:in `require'
/usr/local/www/gitlab/Rakefile:9:in `<top (required)>'
/usr/local/lib/ruby/gems/3.2/gems/rake-13.2.1/lib/rake/rake_module.rb:29:in `load'
/usr/local/lib/ruby/gems/3.2/gems/rake-13.2.1/lib/rake/rake_module.rb:29:in `load_rakefile'
/usr/local/lib/ruby/gems/3.2/gems/rake-13.2.1/lib/rake/application.rb:740:in `raw_load_rakefile'
/usr/local/lib/ruby/gems/3.2/gems/rake-13.2.1/lib/rake/application.rb:126:in `block in load_rakefile'
/usr/local/lib/ruby/gems/3.2/gems/rake-13.2.1/lib/rake/application.rb:214:in `standard_exception_handling'
/usr/local/lib/ruby/gems/3.2/gems/rake-13.2.1/lib/rake/application.rb:125:in `load_rakefile'
/usr/local/lib/ruby/gems/3.2/gems/rake-13.2.1/lib/rake/application.rb:82:in `block in run'
/usr/local/lib/ruby/gems/3.2/gems/rake-13.2.1/lib/rake/application.rb:214:in `standard_exception_handling'
/usr/local/lib/ruby/gems/3.2/gems/rake-13.2.1/lib/rake/application.rb:80:in `run'
/usr/local/lib/ruby/gems/3.2/gems/rake-13.2.1/exe/rake:27:in `<top (required)>'
/usr/local/bin/rake:25:in `load'
/usr/local/bin/rake:25:in `<main>'
root@gitlab:/usr/local/www/gitlab #

It looks as if something has gone wrong with rubygem-aws-sdk-core.  The missing identifier is part of what looks to be an emulated v2 interface of aws-sdk.  I don't know enough to tell if the problem is in rubygem-aws-sdk-core or rubygem-aws-sdk-cloudformation.
Comment 1 Matthias Fechner freebsd_committer freebsd_triage 2024-10-10 05:23:43 UTC
I think I have a solution for this, I will commit it shortly as I currently test version 17.4.2 which is an important security update.
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-10-10 05:44:59 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=487036c6007f3f7393a3737b20c3ece45042e7a4

commit 487036c6007f3f7393a3737b20c3ece45042e7a4
Author:     Matthias Fechner <mfechner@FreeBSD.org>
AuthorDate: 2024-10-10 05:18:21 +0000
Commit:     Matthias Fechner <mfechner@FreeBSD.org>
CommitDate: 2024-10-10 05:28:03 +0000

    www/gitlab: fix problems related to aws-sdk* package upgrades

    Gitlab uses now dedicated packages it requires with the specific version.

    PR:             281980

 devel/Makefile                                     |  4 ++++
 .../Makefile (new)                                 | 20 +++++++++++++++++++
 .../distinfo (new)                                 |  3 +++
 .../pkg-descr (new)                                |  1 +
 devel/rubygem-aws-sdk-core-gitlab/Makefile (new)   | 23 ++++++++++++++++++++++
 devel/rubygem-aws-sdk-core-gitlab/distinfo (new)   |  3 +++
 devel/rubygem-aws-sdk-core-gitlab/pkg-descr (new)  |  2 ++
 devel/rubygem-aws-sdk-kms-gitlab/Makefile (new)    | 21 ++++++++++++++++++++
 devel/rubygem-aws-sdk-kms-gitlab/distinfo (new)    |  3 +++
 devel/rubygem-aws-sdk-kms-gitlab/pkg-descr (new)   |  1 +
 devel/rubygem-aws-sdk-s3-gitlab/Makefile (new)     | 22 +++++++++++++++++++++
 devel/rubygem-aws-sdk-s3-gitlab/distinfo (new)     |  3 +++
 devel/rubygem-aws-sdk-s3-gitlab/pkg-descr (new)    |  1 +
 www/gitlab/Makefile                                |  8 ++++----
 www/gitlab/files/patch-Gemfile                     | 14 +------------
 15 files changed, 112 insertions(+), 17 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-10-10 07:14:15 UTC
A commit in branch 2024Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=68b6289ca0f6f152cdfff1e81d21845982551d68

commit 68b6289ca0f6f152cdfff1e81d21845982551d68
Author:     Matthias Fechner <mfechner@FreeBSD.org>
AuthorDate: 2024-10-10 05:18:21 +0000
Commit:     Matthias Fechner <mfechner@FreeBSD.org>
CommitDate: 2024-10-10 07:06:49 +0000

    www/gitlab: fix problems related to aws-sdk* package upgrades

    Gitlab uses now dedicated packages it requires with the specific version.

    PR:             281980
    (cherry picked from commit 487036c6007f3f7393a3737b20c3ece45042e7a4)

 devel/Makefile                                     |  4 ++++
 .../Makefile (new)                                 | 20 +++++++++++++++++++
 .../distinfo (new)                                 |  3 +++
 .../pkg-descr (new)                                |  1 +
 devel/rubygem-aws-sdk-core-gitlab/Makefile (new)   | 23 ++++++++++++++++++++++
 devel/rubygem-aws-sdk-core-gitlab/distinfo (new)   |  3 +++
 devel/rubygem-aws-sdk-core-gitlab/pkg-descr (new)  |  2 ++
 devel/rubygem-aws-sdk-kms-gitlab/Makefile (new)    | 21 ++++++++++++++++++++
 devel/rubygem-aws-sdk-kms-gitlab/distinfo (new)    |  3 +++
 devel/rubygem-aws-sdk-kms-gitlab/pkg-descr (new)   |  1 +
 devel/rubygem-aws-sdk-s3-gitlab/Makefile (new)     | 22 +++++++++++++++++++++
 devel/rubygem-aws-sdk-s3-gitlab/distinfo (new)     |  3 +++
 devel/rubygem-aws-sdk-s3-gitlab/pkg-descr (new)    |  1 +
 www/gitlab/Makefile                                |  8 ++++----
 www/gitlab/files/patch-Gemfile                     | 14 +------------
 15 files changed, 112 insertions(+), 17 deletions(-)