Bug 281987 - devel/nimble: Upgrade to 0.16.1
Summary: devel/nimble: Upgrade to 0.16.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Zsolt Udvari
URL: https://github.com/nim-lang/nimble/re...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-10 12:54 UTC by Neal Nelson
Modified: 2024-10-22 18:49 UTC (History)
1 user (show)

See Also:


Attachments
Git diff of changes. (2.36 KB, patch)
2024-10-10 12:54 UTC, Neal Nelson
ports: maintainer-approval+
Details | Diff
Git diff of changes. (2.85 KB, patch)
2024-10-11 16:10 UTC, Neal Nelson
ports: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Neal Nelson 2024-10-10 12:54:56 UTC
Created attachment 254133 [details]
Git diff of changes.

Upgrade devel/nimble to the latest 0.16.1 to go with the latest lang/nim 2.2.0.
Comment 1 Zsolt Udvari freebsd_committer freebsd_triage 2024-10-11 09:25:27 UTC
Neal, is it possible to run tests?
See https://docs.freebsd.org/en/books/porters-handbook/book/#make-test
You can define `do-test' target (similar to do-build and do-install).
Comment 2 Neal Nelson 2024-10-11 10:04:55 UTC
(In reply to Zsolt Udvari from comment #1)
I can add this, but probably not until next week.

I just received a notification of the release of 0.16.2, so I'll upgrade to this new release while I'm at it.
Comment 3 Zsolt Udvari freebsd_committer freebsd_triage 2024-10-11 12:56:07 UTC
(In reply to Neal Nelson from comment #2)
Okay, thank you. No rush, no need to hurry.
Comment 4 Neal Nelson 2024-10-11 16:10:07 UTC
Created attachment 254159 [details]
Git diff of changes.

New version upgraded to 0.16.2 and with tests.
Comment 5 Zsolt Udvari freebsd_committer freebsd_triage 2024-10-12 13:03:24 UTC
(In reply to Neal Nelson from comment #4)
The `make test' fails:
===>  Testing for nimble-0.16.2
Downloading Official package list
       Tip: 6 messages have been suppressed, use --verbose to show them.
packageinfo.nim(186)     fetchList

    Error:  Refresh failed
        ... Could not download: No SSL/TLS CA certificates found.
*** Error code 1


Could you please check it?
Comment 6 Neal Nelson 2024-10-21 17:03:56 UTC
(In reply to Zsolt Udvari from comment #5)
I've been bashing my head against this for a while and it seems that I just can't get the tests to work within a clean environment (such as poudriere). They run fine once everything is installed though (at least on my system).

As with all of the other nim tools, nimble tries to be "clever" and wants to download and build everything itself. I've managed to dissuade it from doing that, but it can no longer run the tests, even though it compiles all of the tests fine, it then loses the plot and can no longer find the compiler, even though I have no idea why it wants it. I have yet to find where it's doing this so that I can tell it where the compiler is (even though I've already done that in the command I'm invoking).

So, all in all, I'd say that we should just forget the tests within the ports. The user can run them after installing nimble by just doing 'nim test'.

This is also a bit of a warning that the nim compiler is also becoming more "clever" with each version and really doesn't want to be built the way we do it.
Comment 7 Zsolt Udvari freebsd_committer freebsd_triage 2024-10-22 18:46:04 UTC
(In reply to Neal Nelson from comment #6)
Okay, thanks. If you'd have some time would be worth expanding with tests.
Comment 8 Zsolt Udvari freebsd_committer freebsd_triage 2024-10-22 18:49:23 UTC
Committed, thanks!
Comment 9 commit-hook freebsd_committer freebsd_triage 2024-10-22 18:49:35 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5f182663e7b1c6c77cbe5bbb88dfb976a7246ccb

commit 5f182663e7b1c6c77cbe5bbb88dfb976a7246ccb
Author:     Neal Nelson <ports@nicandneal.net>
AuthorDate: 2024-10-22 18:46:18 +0000
Commit:     Zsolt Udvari <uzsolt@FreeBSD.org>
CommitDate: 2024-10-22 18:46:18 +0000

    devel/nimble: Update to 0.16.2

    Changelogs:
    * https://github.com/nim-lang/nimble/releases/tag/v0.16.2
    * https://github.com/nim-lang/nimble/releases/tag/v0.16.1

    PR:             281987
    Approved by:    submitter is maintainer

 devel/nimble/Makefile | 10 ++++++----
 devel/nimble/distinfo | 14 +++++++-------
 2 files changed, 13 insertions(+), 11 deletions(-)