Bug 281999 - graphics/alembic: Unbreak and improve port
Summary: graphics/alembic: Unbreak and improve port
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alexey Dokuchaev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-11 00:24 UTC by Daniel Engberg
Modified: 2024-11-26 08:29 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (danfe)

Attachments
Patch for alembic (2.21 KB, patch)
2024-10-11 00:24 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-10-11 00:24:50 UTC 
Created attachment 254148 [details]
Patch for alembic

* Refresh distinfo
* Remove libaec (not used) dependency
* Remove USE_CXXSTD (-std=c++14 gets applied afterwards since upstream expects users to use CMAKE_CXX_STANDARD)
* Use USES= cmake:testing
* Only build unit tests when requested
* Unit tests fails due to race conditions, disable parallel runs
* Use OPT_CMAKE_BOOL helper

Compile and runtime tested on FreeBSD 14.1-RELEASE (amd64) (make, make check-plist, make test)

Poudriere testport OK 13.3-RELEASE (amd64)
Poudriere testport OK 14.1-RELEASE (amd64)
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-10-17 19:21:20 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6ded0172cbc62e45b9439367d74370ee73531611

commit 6ded0172cbc62e45b9439367d74370ee73531611
Author:     Alexey Dokuchaev <danfe@FreeBSD.org>
AuthorDate: 2024-10-17 19:19:48 +0000
Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
CommitDate: 2024-10-17 19:19:48 +0000

    graphics/alembic: unbreak the fetch and drop needless LIB_DEPENDS

    - Distfile had been rerolled upstream to remove experimental tweak
      that accidentally snuck its way in (diff-verified)
    - Do not force linking against `science/libaec' which is not used
      directly and could only be pulled via optional `science/hdf5',
      where it is also subject to SZIP option

    Reported by:    vvd, pkg-fallout, Mamoru Iwaki
    PR:             282157, 281999 (first take)

 graphics/alembic/Makefile | 1 -
 graphics/alembic/distinfo | 6 +++---
 2 files changed, 3 insertions(+), 4 deletions(-)
Comment 2 Alexey Dokuchaev freebsd_committer freebsd_triage 2024-11-26 08:29:30 UTC 
Reopen prematurely closed PR (not all suggestions were processed).