Bug 282010 - sysutils/topgrade: Update to 16.0.1
Summary: sysutils/topgrade: Update to 16.0.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Rodrigo Osorio
URL: https://github.com/topgrade-rs/topgra...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-11 11:00 UTC by freebsd
Modified: 2025-02-18 15:24 UTC (History)
2 users (show)

See Also:


Attachments
patch.diff (17.58 KB, patch)
2024-10-11 11:00 UTC, freebsd
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description freebsd 2024-10-11 11:00:38 UTC
Created attachment 254156 [details]
patch.diff

Hi,

Please commit the patch.diff to upgrade topgrade to 16.0.1

Thanks in advance.

Best,
C.
Comment 1 freebsd 2024-10-11 11:02:56 UTC
Hi,


Would it not be make sense to implement an auto upgrade process for such of ports like this, or does it already exists ?


Best,
C.
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-10-18 12:52:44 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=17784cbc27aa4f335daa4664e519876d10472957

commit 17784cbc27aa4f335daa4664e519876d10472957
Author:     Rodrigo Osorio <rodrigo@FreeBSD.org>
AuthorDate: 2024-10-18 08:57:07 +0000
Commit:     Rodrigo Osorio <rodrigo@FreeBSD.org>
CommitDate: 2024-10-18 12:48:18 +0000

    sysutils/topgrade: update to 16.0.1

    Changelog: https://github.com/topgrade-rs/topgrade/releases/tag/v16.0.1

    PR:             282010
    Reported by:    <freebsd@scd-systems.net> (maintainer)

 sysutils/topgrade/Makefile        |  3 +--
 sysutils/topgrade/Makefile.crates | 30 ++++++++++++++++++++--
 sysutils/topgrade/distinfo        | 54 ++++++++++++++++++++++++++++++++++-----
 3 files changed, 76 insertions(+), 11 deletions(-)
Comment 3 Rodrigo Osorio freebsd_committer freebsd_triage 2024-10-18 12:57:19 UTC
Committed with minor changes, thanks.
I close the PR but we can still discussing.

What do you mean by "auto upgrade process" for ports ? A process who perform port upgrades on user computers for dedicated application ?

cheers,
-- rodrigo
Comment 4 freebsd 2024-10-21 19:16:04 UTC
(In reply to Rodrigo Osorio from comment #3)

Hi Rodrigo,

Thank you very much for the merge.

Regarding "auto upgrade process".

My question is about why I do need to create a merge request ticket manually just for a simple patch which can be done by a cronjob or task which can be run in background.
The patch it self was generated by just some make and git commands (always the same).
This could also be done by a CI job, right ?

The idea whould be to trigger a job runner to generate the patches automatically when the port-scout detects a new program version.

Best,
Cliff
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2025-02-18 15:24:58 UTC
(In reply to freebsd from comment #4)

Automated processes cannot ensure that the updated port actually works fine.  To do that, you need to test the software after updating it.  I hope you're doing so, are you?

Note that this update added some garbage to sysutils/topgrade/Makefile.crates.
It's surprising that it seems to build despite there being garbage in the file.
Please make sure you manually review all patches you submit for correctness before you submit them.  Otherwise you're just wasting people's time.

... and this sort of stuff is why you can't update your ports with a cron job.