Bug 282011 - www/tgpt: Update to 2.8.2
Summary: www/tgpt: Update to 2.8.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-11 11:01 UTC by Yusuf Yaman
Modified: 2024-10-12 20:46 UTC (History)
2 users (show)

See Also:


Attachments
www/tgpt.patch (1.46 KB, patch)
2024-10-11 11:02 UTC, Yusuf Yaman
nxjoseph: maintainer-approval+
Details | Diff
v1 (broken whitespaces) (3.33 KB, patch)
2024-10-11 17:24 UTC, Vladimir Druzenko
no flags Details | Diff
www/tgpt.patch (3.26 KB, patch)
2024-10-12 12:23 UTC, Yusuf Yaman
nxjoseph: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuf Yaman 2024-10-11 11:01:46 UTC

    
Comment 1 Yusuf Yaman 2024-10-11 11:02:32 UTC
Created attachment 254157 [details]
www/tgpt.patch

Changelog:
https://github.com/aandrew-me/tgpt/releases/tag/v2.8.2
Comment 2 Yusuf Yaman 2024-10-11 11:02:54 UTC
Thanks.
Comment 3 Vladimir Druzenko freebsd_committer freebsd_triage 2024-10-11 16:18:20 UTC
make makesum generate 2 similar records in distinfo:
SHA256 (charmbracelet-x-v0.1.0_GH0.tar.gz) = f876110994066651d62c6e5ea1f94534a6e58f456bdc22849f3cecfa8836d0ed
SIZE (charmbracelet-x-v0.1.0_GH0.tar.gz) = 10317
SHA256 (charmbracelet-x-v0.1.0_GH0.tar.gz) = f876110994066651d62c6e5ea1f94534a6e58f456bdc22849f3cecfa8836d0ed
SIZE (charmbracelet-x-v0.1.0_GH0.tar.gz) = 10317

Perhaps the reason is this:
charmbracelet:x:v0.1.0:charmbracelet_x_input/vendor/github.com/charmbracelet/x/input \
charmbracelet:x:v0.1.0:charmbracelet_x_windows/vendor/github.com/charmbracelet/x/windows \
Comment 4 Yusuf Yaman 2024-10-11 16:22:20 UTC
(In reply to Vladimir Druzenko from comment #3)
Yes, thanks for reporting what's likely causing it.

I ran portlint and it said me there are duplicate entries in distinfo so i manually removed one of them in distinfo and this was my workaround.

How should we handle this?

I already updated distinfo in the patch, do you need to run make makesum again?

Thanks.
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2024-10-11 17:07:30 UTC
(In reply to Yusuf Yaman from comment #4)
> I already updated distinfo in the patch, do you need to run make makesum again?
I must test this before commit too.

Tested this change:
charmbracelet:x:input/v0.1.0:charmbracelet_x_input/vendor/github.com/charmbracelet/x/charmbracelet:x:windows/v0.1.0:charmbracelet_x_windows/vendor/github.com/charmbracelet/x/windows \
Build fine.

Do we need "charmbracelet windows"?
Looks like this windows only module:
https://github.com/charmbracelet/x/blob/main/windows/types_windows.go
Build fine without it.
Comment 6 Yusuf Yaman 2024-10-11 17:17:31 UTC
(In reply to Vladimir Druzenko from comment #5)
I couldn't imagine what changes you've made. It seems to be a module for Windows API. I think we can remove it if it built fine without it.
Comment 7 Vladimir Druzenko freebsd_committer freebsd_triage 2024-10-11 17:21:14 UTC
(In reply to Yusuf Yaman from comment #6)
Can you test runtime after remove "charmbracelet:x:v0.1.0:charmbracelet_x_windows/vendor/github.com/charmbracelet/x/windows" and rebuild?
Comment 8 Vladimir Druzenko freebsd_committer freebsd_triage 2024-10-11 17:24:43 UTC
Created attachment 254160 [details]
v1 (broken whitespaces)

Diff for review.
Comment 9 Yusuf Yaman 2024-10-12 12:23:20 UTC
Created attachment 254172 [details]
www/tgpt.patch

Thanks for sending diff.

I tested runtime and it works fine.

I'm attaching the recent patch.
Comment 10 commit-hook freebsd_committer freebsd_triage 2024-10-12 20:42:32 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a1b339df9c5c6a27906c94fb671b2890eae50d70

commit a1b339df9c5c6a27906c94fb671b2890eae50d70
Author:     Yusuf Yaman <nxjoseph@protonmail.com>
AuthorDate: 2024-10-12 20:38:45 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-10-12 20:38:45 +0000

    www/tgpt: Update 2.8.1 → 2.8.2

    Changelog:
    https://github.com/aandrew-me/tgpt/releases/tag/v2.8.2

    Remove windows-only module github.com/charmbracelet/x/windows.

    PR:     282011

 www/tgpt/Makefile |  6 ++----
 www/tgpt/distinfo | 10 +++++-----
 2 files changed, 7 insertions(+), 9 deletions(-)
Comment 11 Vladimir Druzenko freebsd_committer freebsd_triage 2024-10-12 20:45:56 UTC
Thanks.
Comment 12 Yusuf Yaman 2024-10-12 20:46:39 UTC
(In reply to Vladimir Druzenko from comment #11)
You are welcome and thanks for giving a look.