Bug 282018 - devel/sol2: fix dependant ports build failure with clang 18
Summary: devel/sol2: fix dependant ports build failure with clang 18
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-11 19:36 UTC by Pavel Timofeev
Modified: 2024-10-15 03:56 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (yuri)

Attachments
port patch (2.33 KB, patch)
2024-10-11 19:36 UTC, Pavel Timofeev 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Timofeev 2024-10-11 19:36:59 UTC 
Created attachment 254167 [details]
port patch

Hello

This was reported in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281741

Fix discussion https://github.com/ThePhD/sol2/issues/1581

Pick this fix up.

Makes sense to add this to quarterly branch as well.
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2024-10-11 19:45:51 UTC 
(In reply to Pavel Timofeev from comment #0)

Pavel,

Thanks for the patch.

I think that it would be great if you would also submit it to upstream as a pull request, so that other people would also benefit from it.


Yuri
Comment 2 Pavel Timofeev 2024-10-11 21:33:16 UTC 
sol2 has open issue on github about this problem https://github.com/ThePhD/sol2/issues/1581.
I'm not sure why sol2 hasn't picked it up.
Comment 3 Pavel Timofeev 2024-10-14 16:47:59 UTC 
Sorry to bother you.
Is there any problem with merging this into the ports tree?
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2024-10-14 17:08:47 UTC 
Committed, thanks!
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-10-14 17:08:52 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=36244079e47839605d7ad2a55edc67ec25784fd3

commit 36244079e47839605d7ad2a55edc67ec25784fd3
Author:     Pavel Timofeev <timp87@gmail.com>
AuthorDate: 2024-10-14 15:02:33 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2024-10-14 17:08:37 +0000

    devel/sol2: fix dependant ports build failure with clang 18

    PR:             282018

 devel/sol2/Makefile                                | 10 ++++++++-
 ...nclude_sol_function__types__stateless.hpp (new) | 24 ++++++++++++++++++++++
 2 files changed, 33 insertions(+), 1 deletion(-)
Comment 6 Pavel Timofeev 2024-10-14 18:35:32 UTC 
Can you please commit it to the current quarterly branch as well? Maybe after some time.
2024Q4 is built against freebsd 14.1 now, so I'm getting build failure emails from quarterly branch pipeline about my port which is a dependant of sol2
Comment 7 commit-hook freebsd_committer freebsd_triage 2024-10-15 03:38:19 UTC 
A commit in branch 2024Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ce57a1a89fb6b3fb64d93cbb5383a4a6008b3bb1

commit ce57a1a89fb6b3fb64d93cbb5383a4a6008b3bb1
Author:     Pavel Timofeev <timp87@gmail.com>
AuthorDate: 2024-10-14 15:02:33 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2024-10-15 03:37:52 +0000

    devel/sol2: fix dependant ports build failure with clang 18

    PR:             282018
    (cherry picked from commit 36244079e47839605d7ad2a55edc67ec25784fd3)

 devel/sol2/Makefile                                | 10 ++++++++-
 ...nclude_sol_function__types__stateless.hpp (new) | 24 ++++++++++++++++++++++
 2 files changed, 33 insertions(+), 1 deletion(-)
Comment 8 Yuri Victorovich freebsd_committer freebsd_triage 2024-10-15 03:38:30 UTC 
(In reply to Pavel Timofeev from comment #6)

Done.
Comment 9 Pavel Timofeev 2024-10-15 03:56:14 UTC 
Thank you very much!