Bug 282035 - devel/cargo-edit: Deprecate port
Summary: devel/cargo-edit: Deprecate port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-12 16:17 UTC by Yonas Yanfa
Modified: 2024-10-14 04:15 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (yuri)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yonas Yanfa 2024-10-12 16:17:43 UTC
`cargo add/remove` has been merged upstream.
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2024-10-13 23:11:38 UTC
(In reply to Yonas Yanfa from comment #0)

Hi Yonas,

The README page at https://github.com/killercup/cargo-edit says that cargo-edit adds commands "cargo upgrade" and "cargo set-version", not "cargo add/remove".
Comment 2 Yonas Yanfa 2024-10-14 00:50:32 UTC
Literally the first sentence:

> This tool extends Cargo to allow you to add, remove, and upgrade dependencies by modifying your Cargo.toml file from the command line.


We should remove these from the port (remove from PLIST):

/usr/local/bin/cargo-add
/usr/local/bin/cargo-rm


Lastly, the upgrade feature has been absorbed upstream, but currently requires unstable. When it's stable, we should also remove `/usr/local/bin/cargo-upgrade`.


`/usr/local/bin/cargo-set-version` is the only program we should be packaging, but if it's the only program left, a more accurate name for the port would be cargo-set-version. Seeing how the set-version feature has only received formatting / style changes over the past few years, I'd be happy to fork it to slim down the whole project.
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2024-10-14 04:14:23 UTC
Removed 2 commands that were merged.

Please reopen if/when other commands will be merged.
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-10-14 04:15:40 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a238e533bd23a873560e25e8ef1d83fc321e0509

commit a238e533bd23a873560e25e8ef1d83fc321e0509
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2024-10-14 04:03:11 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2024-10-14 04:14:31 +0000

    devel/cargo-edit: Remove

    PR:             282035
    Reported by:    Yonas Yanfa <yonas.yanfa@gmail.com>

 devel/cargo-edit/Makefile | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)