Bug 282056 - cad/Clipper2: Switch to shared library and improve port
Summary: cad/Clipper2: Switch to shared library and improve port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Michael Reifenberger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-13 16:11 UTC by Daniel Engberg
Modified: 2024-10-13 17:12 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (mr)

Attachments
Patch for Clipper2 (2.35 KB, patch)
2024-10-13 16:11 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-10-13 16:11:05 UTC 
Created attachment 254206 [details]
Patch for Clipper2

* Use upstream release archive as recommended by Porters Handbook
* Set USES= compiler:c++17-lang and pathfix
* Remove CMAKE_SOURCE_PATH and use WRKSRC_SUBDIR + NO_WRKSUBDIR
* Don't build tests

Compile tested on FreeBSD 14.1 (amd64)

Compile tested in Poudriere using FreeBSD 14.1 (amd64) with cad/openscad
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-10-13 16:52:00 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ac1e9fccf815f5c70361d8040530643952bf3615

commit ac1e9fccf815f5c70361d8040530643952bf3615
Author:     Michael Reifenberger <mr@FreeBSD.org>
AuthorDate: 2024-10-13 16:47:03 +0000
Commit:     Michael Reifenberger <mr@FreeBSD.org>
CommitDate: 2024-10-13 16:50:56 +0000

    cad/Clipper2: Build shared lib

    Switch to shared library and improve port
    Bump PORTREVISION

    PR:             282056
    Reported by:    Daniel Engberg zzy@

 cad/Clipper2/Makefile       | 21 ++++++++++-----------
 cad/Clipper2/distinfo       |  8 +++-----
 cad/Clipper2/pkg-plist      |  8 ++++++--
 cad/openscad-devel/Makefile |  2 +-
 cad/openscad/Makefile       |  2 +-
 5 files changed, 21 insertions(+), 20 deletions(-)
Comment 2 Michael Reifenberger freebsd_committer freebsd_triage 2024-10-13 16:54:50 UTC 
Hi,
I did not intent to use the lib outside of openscad and I ported it only 
because openscad requires it so I didn't care for the sharedlibs.

Thanks for the patches!
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-10-13 17:12:03 UTC 
A commit in branch 2024Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9d93248f5eadf985026df5e381593288a45c9eff

commit 9d93248f5eadf985026df5e381593288a45c9eff
Author:     Michael Reifenberger <mr@FreeBSD.org>
AuthorDate: 2024-10-13 16:47:03 +0000
Commit:     Michael Reifenberger <mr@FreeBSD.org>
CommitDate: 2024-10-13 17:10:40 +0000

    cad/Clipper2: Build shared lib

    Switch to shared library and improve port
    Bump PORTREVISION

    PR:             282056
    Reported by:    Daniel Engberg zzy@

    (cherry picked from commit ac1e9fccf815f5c70361d8040530643952bf3615)

 cad/Clipper2/Makefile       | 21 ++++++++++-----------
 cad/Clipper2/distinfo       |  8 +++-----
 cad/Clipper2/pkg-plist      |  8 ++++++--
 cad/openscad-devel/Makefile |  2 +-
 cad/openscad/Makefile       |  2 +-
 5 files changed, 21 insertions(+), 20 deletions(-)