Bug 282181 - emulators/winetricks: Update to 20241017
Summary: emulators/winetricks: Update to 20241017
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Zsolt Udvari
URL: https://github.com/Winetricks/winetri...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-18 16:49 UTC by Alexander Vereeken
Modified: 2024-10-27 07:02 UTC (History)
2 users (show)

See Also:


Attachments
0001-emulators-winetricks-Update-to-20241017.patch (1.55 KB, patch)
2024-10-18 16:57 UTC, Alexander Vereeken
Alexander88207: maintainer-approval+
Details | Diff
Add test (1.87 KB, patch)
2024-10-23 08:33 UTC, Zsolt Udvari
Alexander88207: maintainer-approval-
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Vereeken freebsd_triage 2024-10-18 16:49:39 UTC
Hello,

this is an update to 20241017.

Thank you in advance!
Comment 1 Alexander Vereeken freebsd_triage 2024-10-18 16:57:28 UTC
Created attachment 254342 [details]
0001-emulators-winetricks-Update-to-20241017.patch
Comment 2 Zsolt Udvari freebsd_committer freebsd_triage 2024-10-23 08:33:51 UTC
Created attachment 254457 [details]
Add test

Thanks for submission.

I added TEST_TARGET and TEST_DEPENDS to test the port (see https://docs.freebsd.org/en/books/porters-handbook/book/#make-test). But the `make test' fails.
Could you please check?

Maybe it's worth add a new patch with removes 'set -x' from tests/* because it's very annoying.
Comment 3 Alexander Vereeken freebsd_triage 2024-10-24 19:35:03 UTC
Comment on attachment 254457 [details]
Add test

(In reply to Zsolt Udvari from comment #2)

Hello,

thanks for your patch, but...sorry.

make test here is insane as every single verb is run through.

I have run some verbs successfully, but i won't sit this out completely (and every time after an update) and therefore won't include/maintain this part.
Comment 4 Zsolt Udvari freebsd_committer freebsd_triage 2024-10-27 07:02:25 UTC
(In reply to Alexander Vereeken from comment #3)
Okay. Committed the original patch. Thanks!
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-10-27 07:02:46 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=83043a557c15a4b7c5c69c7e9bdf51f8027017fb

commit 83043a557c15a4b7c5c69c7e9bdf51f8027017fb
Author:     Alexander Vereeken <Alexander88207@protonmail.com>
AuthorDate: 2024-10-27 07:00:32 +0000
Commit:     Zsolt Udvari <uzsolt@FreeBSD.org>
CommitDate: 2024-10-27 07:00:32 +0000

    emulators/winetricks: Update to 20241017

    Switch to DISTVERSION.

    PR:             282181
    Approved by:    submitter is maintainer

 emulators/winetricks/Makefile | 5 +++--
 emulators/winetricks/distinfo | 6 +++---
 2 files changed, 6 insertions(+), 5 deletions(-)