Bug 282186 - multimedia/audacious-plugins: missing plugin Amidi
Summary: multimedia/audacious-plugins: missing plugin Amidi
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Many People
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-18 22:34 UTC by Alex
Modified: 2024-10-24 05:52 UTC (History)
0 users

See Also:
madpilot: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alex 2024-10-18 22:34:32 UTC
The audacious-plugins pkg on FreeBSD lacks the Amidi plugin, leaving users without MIDI playback. This can be a major inconvenience for former Linux users that have switched to FreeBSD and expect the same feature set as on Linux.

A similar request was posted as early as in 2010 (147277), but the current pkg still does not have this plugin enabled.
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2024-10-18 23:13:07 UTC
Hi,

I'm going to take a look. It looks like there is not that much more dependencies added.

There are some consideration due to how FreeBSD ports work and how options in audacious-plugins and the amidi added dependency on audio/fluidsynth will pan out.

It's not easy to strike an equilibrium in this. How many FreeBSD users actually need MIDI support? There is no easy way to know, it could be many, just a few, or just you. How many will be annoyed by one more dependency? This is also not easy to guess exactly but it easy to say there will be at least a few.

Anyway I'm taking a look, it is possible it makes ense to just enable it.


As a sidenote I feel the need to point out that catering to Linux users expectations is not FreeBSD business. FreeBSD users often have different expectations, and those have precedence. Also, as a dedicated FreeBSD user I have no idea of what a Linux user would expect, guessing is not going to help either. But FreeBSD users expectations could be different, and a Linux user moving to FreeBSD should adapt himself to FreeBSD expectations, or keep using Linux (or whatever else).

So this argument of yours is not very effective on me.


Regarding the request in 2010, it was fulfilled by adding the option off by default. At the time most users were building from ports anyway, the binary packages offering was not really usable back then.

For the sake of argument, the fact that nobody spoke about MIDI since can also be read to mean that for 14 years nobody cared for MIDI support.
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-10-24 05:49:51 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=73054fd089ab8f7c9d918e3c5a14195a362bbf2d

commit 73054fd089ab8f7c9d918e3c5a14195a362bbf2d
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2024-10-24 05:47:14 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2024-10-24 05:48:17 +0000

    multimedia/audacious-plugins: Enable AMIDI and JACK options by default

    On user request enable AMIDI by default.

    Since this adds a dependency on audio/fluidsynth which, by default,
    also depends on jack, enable jack here too.

    PR:             282186
    MFH:            2024Q4

 multimedia/audacious-plugins/Makefile | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-10-24 05:50:52 UTC
A commit in branch 2024Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bdcd993e58ce6bf4d41eb8fd4948122c37f4c849

commit bdcd993e58ce6bf4d41eb8fd4948122c37f4c849
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2024-10-24 05:47:14 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2024-10-24 05:49:45 +0000

    multimedia/audacious-plugins: Enable AMIDI and JACK options by default

    On user request enable AMIDI by default.

    Since this adds a dependency on audio/fluidsynth which, by default,
    also depends on jack, enable jack here too.

    PR:             282186
    MFH:            2024Q4
    (cherry picked from commit 73054fd089ab8f7c9d918e3c5a14195a362bbf2d)

 multimedia/audacious-plugins/Makefile | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Comment 4 Guido Falsi freebsd_committer freebsd_triage 2024-10-24 05:52:12 UTC
Option enabled by default.

It really adds little extra dependencies, and the ports chapter actually opts to strive for functionality when it's not excessive burden.

Thanks!