Created attachment 254381 [details] patch to 1.13.3 Updating to 1.13.3. It seems like that a lot of FreeBSD-related patches are merged now, thanks to Aleksandar Fabijanic (https://github.com/pocoproject/poco/commit/0818febed3c78a77fd6c53129a791af5d7aecd63). Thus, we can delete some patches. On the other hand, it seems like that some compilation issues exist now, in the test code.
Created attachment 254382 [details] poudriere log on 13.4-RELEASE
Created attachment 254383 [details] poudriere log on 14.1-RELEASE
SHLIB_MAJOR changed - need to bump all consumers: audio/mumble multimedia/nymphcastlib multimedia/nymphrpc multimedia/nymphcast security/clamfs And better to do small exp-run.
audio/mumble build fine. multimedia/nymphrpc fails.
(In reply to Vladimir Druzenko from comment #4) okay, nymphrpc is being built with c++11, while the new version of poco uses stuff from c++14 or later, such as underlying_type_t. Seems like that it's broken since 1.12.5: https://github.com/MayaPosch/NymphRPC/issues/9 People said that it'll work with c++14, so I'll try that.
Created attachment 254401 [details] patch for nymphrpc to use c++14 poco >= 1.12.5 needs at least c++14; nymphrpc uses c++11; here's a patch to compile it with c++14. It now compiles with new poco.
multimedia/nymphcastlib multimedia/nymphcast security/clamfs seems to be okay.
(In reply to Henry Hu from comment #7) Thanks for patch! But we need approve from maintainer adridg@ - already added in CC. But I can commit it as "fix build" without waiting approve or 14 days timeout… Lets wait till tomorrow.
BTW, good practice is to report bugs and send patches to upstream.
(In reply to Vladimir Druzenko from comment #9) I think the author is aware of the issue (see https://github.com/MayaPosch/NymphRPC/issues/9, the last commenter is the repo owner). It's already fixed in the latest upstream (https://github.com/MayaPosch/NymphRPC/blob/9df6ebf2fc343daca229dc72b0d0696968a13fc4/Makefile#L117). I think the owner just needs to create a new release.
If you can land a build fix for nymphrpc (e.g. the one described upstream), that'd be great. (So you have approval to land what's necessary in my ports for this PR)
Last tests in progress and then commit!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=afabf7e5e9d9309038f97017dfe689be6b9a6964 commit afabf7e5e9d9309038f97017dfe689be6b9a6964 Author: Vladimir Druzenko <vvd@FreeBSD.org> AuthorDate: 2024-10-21 23:07:54 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2024-10-21 23:40:45 +0000 */*: Bump after update devel/poco Bump PORTREVISION for all consumers of the devel/poco. In multimedia/nymphrpc add patch from upstream to support newer poco: https://github.com/MayaPosch/NymphRPC/commit/d56411046e06ec33ec8e81f05aa568c28380a679 https://github.com/MayaPosch/NymphRPC/issues/9 security/clamfs: while here replace PORTVERSION with DISTVERSION and remove GNU_CONFIGURE_MANPREFIX. PR: 282219 Approved by: adridg audio/mumble/Makefile | 2 +- multimedia/nymphcast/Makefile | 2 +- multimedia/nymphcastlib/Makefile | 2 +- multimedia/nymphrpc/Makefile | 2 +- multimedia/nymphrpc/files/patch-Makefile | 21 +++++++++++---------- security/clamfs/Makefile | 7 +++---- 6 files changed, 18 insertions(+), 18 deletions(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=584922c9146158a08a4896fe4d2c8e7c134a808d commit 584922c9146158a08a4896fe4d2c8e7c134a808d Author: Henry Hu <henry.hu.sh@gmail.com> AuthorDate: 2024-10-21 22:40:52 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2024-10-21 23:40:45 +0000 devel/poco: Update 1.12.4 → 1.13.3 Changelogs: https://github.com/pocoproject/poco/releases/tag/poco-1.12.5-release https://github.com/pocoproject/poco/releases/tag/poco-1.12.5p1-release https://github.com/pocoproject/poco/releases/tag/poco-1.12.5p2-release https://github.com/pocoproject/poco/releases/tag/poco-1.13.0-release https://github.com/pocoproject/poco/releases/tag/poco-1.13.1-release https://github.com/pocoproject/poco/releases/tag/poco-1.13.2-release https://github.com/pocoproject/poco/releases/tag/poco-1.13.3-release PR: 282219 devel/poco/Makefile | 8 +--- devel/poco/distinfo | 6 +-- .../patch-Crypto_src_OpenSSLInitializer.cpp (gone) | 10 ----- ...tch-Data_ODBC_testsuite_src_SQLExecutor.h (new) | 42 +++++++++++++++++++ .../patch-Foundation_src_Thread__POSIX.cpp (gone) | 49 ---------------------- devel/poco/pkg-plist | 17 ++++---- 6 files changed, 56 insertions(+), 76 deletions(-)
Thanks!