Created attachment 254400 [details] git format-patch for cde pkg-messages Attempt to clarify instructions. startx won't look for .Xsession unless asked to. cmw's Xsession asks not to change it, so it's not necessary to link it into the user's home directory. Most people won't have inetd running, so start that when we start the other services. Typed from cde-devel on current, this is so cool! Thanks!
I cannot accept this patch. PORTREVISION bump is needed.
Created attachment 254402 [details] Improved description I've copied the description from the CDE project and made another improvement. The comment that it's ancient isn't accurate and written by someone much younger than me.
Created attachment 254403 [details] Improved patch version 2 Here are a list of changes: 1. I've copied the description from the CDE project page. 2. We absolutely need a PORTREVISION bump for this type of update. 3. We should not forget x11/cde-devel. I've added that patch. 4. The commit subject line must contian the port origin. In this case for both cde ports it should be x11/cde*. 5. The PR number has been added to the commit log message. 6. We do not MFC ports. There is no time limit. We MFH ports to 2024Q4. This change does not qualify for MFH to quarterly. Sorry. In the future maybe this kind of patch should be submitted to phabricator (or github) where you and I can interactively discuss each line of the patch, rather than me replacing entire parts of the patch. We can still use the PR to point to either.
That's a big improvement. Sorry, new to ports and didn't know about portrevision and MFH. Polished some typos before my laptop died, I'll upload when I get home. Phab sounds so much better, git-arc.sh works perfect. My order of preference is (using what maintainers want me to use first and formost) github > phab > bugs.
github is the best because it shows my activity in way that everyone understands.
If phabricator, I'm notified when you add me as a reviewer. If github, I don't read my github email, too much. Then simply send me an email to remind me.
Created attachment 254429 [details] cde-package-message-v3
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=d95bff830c4e12c76d4d31554846a5a2b78ae720 commit d95bff830c4e12c76d4d31554846a5a2b78ae720 Author: Alexander Ziaee <concussious@runbox.com> AuthorDate: 2024-10-20 13:52:51 +0000 Commit: Cy Schubert <cy@FreeBSD.org> CommitDate: 2024-10-21 23:43:54 +0000 x11/cde*: Improve pkg-message + history from upstream + improve sysrc examples + apply editorial polish + startx without linking PR: 282229 Discussed with: cy x11/cde-25/Makefile | 2 +- x11/cde-25/files/pkg-message.in | 42 ++++++++++++++++++++------------------ x11/cde-devel/Makefile | 2 +- x11/cde-devel/files/pkg-message.in | 42 ++++++++++++++++++++------------------ 4 files changed, 46 insertions(+), 42 deletions(-)