Bug 282239 - cad/horizon-eda: Prepare for libgit2 1.8.2
Summary: cad/horizon-eda: Prepare for libgit2 1.8.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL:
Keywords:
Depends on:
Blocks: 282262
  Show dependency tree / graph
 
Reported: 2024-10-21 07:45 UTC by Nuno Teixeira
Modified: 2024-10-22 10:21 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (yuri)

Attachments
Fix build with libgit2 1.8.2 (1.09 KB, patch)
2024-10-21 07:45 UTC, Nuno Teixeira 		no flags Details | Diff
Fix build with libgit2 1.8.2: Use tabs instead of spaces (1.08 KB, patch)
2024-10-21 07:47 UTC, Nuno Teixeira 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nuno Teixeira freebsd_committer freebsd_triage 2024-10-21 07:45:08 UTC 
Created attachment 254417 [details]
Fix build with libgit2 1.8.2

Hello Yuri,

Upstream patch to fix build with upcoming libgit2 1.8.2.
My sugestion is to apply it now without bump portrevision as it only changes:

```diff
- #if (LIBGIT2_VER_MAJOR == 1) && (LIBGIT2_VER_MINOR == 8)
+ #if (LIBGIT2_VER_MAJOR == 1) && (LIBGIT2_VER_MINOR == 8) && (LIBGIT2_VER_REVISION < 2)
```
reflecting libgit2 const backport from 1.8.2

See also: https://github.com/horizon-eda/horizon/issues/788

Cheers
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2024-10-21 07:47:01 UTC 
Created attachment 254418 [details]
Fix build with libgit2 1.8.2: Use tabs instead of spaces
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2024-10-21 08:22:36 UTC 
Hello Nuno,

Approved, please commit it.

Thanks,
Yuri
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-10-22 07:14:11 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ad266f7ef9dfa9b6c0641c9b658458b45d0e3f0c

commit ad266f7ef9dfa9b6c0641c9b658458b45d0e3f0c
Author:     Nuno Teixeira <eduardo@FreeBSD.org>
AuthorDate: 2024-10-22 07:11:13 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2024-10-22 07:13:23 +0000

    cad/horizon-eda: Prepare for libgit2 1.8.2

    Upstream patch to fix build with upcoming libgit2 1.8.2.

    PR:             282239

 cad/horizon-eda/Makefile | 3 +++
 cad/horizon-eda/distinfo | 4 +++-
 2 files changed, 6 insertions(+), 1 deletion(-)
Comment 4 Nuno Teixeira freebsd_committer freebsd_triage 2024-10-22 10:21:31 UTC 
Committed, thanks!