Bug 282319 - x11/plasma[56]-plasma-desktop: fix build with clang 19
Summary: x11/plasma[56]-plasma-desktop: fix build with clang 19
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-kde (group)
URL: https://bugs.kde.org/show_bug.cgi?id=...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-25 10:04 UTC by Jung-uk Kim
Modified: 2024-10-26 05:59 UTC (History)
2 users (show)

See Also:
jhale: maintainer-feedback+


Attachments
Fix build with clang 19 (1.69 KB, patch)
2024-10-25 10:04 UTC, Jung-uk Kim
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jung-uk Kim freebsd_committer freebsd_triage 2024-10-25 10:04:09 UTC
Created attachment 254506 [details]
Fix build with clang 19

x11/plasma6-plasma-desktop fails to build with clang 19.

[ 42% 389/912] cd /usr/ports/x11/plasma6-plasma-desktop/work/.build/kcms/libkwindevices && /usr/local/libexec/qt6/moc @/usr/ports/x11/plasma6-plasma-desktop/work/.build/kcms/libkwindevices/moc_InputDevice_interface.cpp_parameters
[ 42% 390/912] /usr/local/libexec/ccache/c++ -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_NO_CAST_TO_ASCII -DQT_NO_DEBUG -DQT_NO_FOREACH -DQT_NO_NARROWING_CONVERSIONS_IN_CONNECT -DQT_NO_URL_CAST_FROM_STRING -DQT_USE_QSTRINGBUILDER -D_LARGEFILE64_SOURCE -I/usr/ports/x11/plasma6-plasma-desktop/work/.build/kcms/libkwindevices -I/usr/ports/x11/plasma6-plasma-desktop/work/plasma-desktop-6.1.2/kcms/libkwindevices -I/usr/ports/x11/plasma6-plasma-desktop/work/.build/kcms/libkwindevices/kwindevices_autogen/include -I/usr/ports/x11/plasma6-plasma-desktop/work/.build -isystem /usr/local/include/qt6/QtCore -isystem /usr/local/include/qt6 -isystem /usr/local/lib/qt6/mkspecs/freebsd-clang -isystem /usr/local/include/qt6/QtDBus -O2 -pipe -march=znver3 -fstack-protector-strong -fno-strict-aliasing -fno-operator-names -fno-exceptions -Wno-gnu-zero-variadic-macro-arguments -Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -Wnon-virtual-dtor -Woverloaded-virtual -Werror=return-type -Werror=init-self -Wvla -Wdate-time -pedantic -Wzero-as-null-pointer-constant -fdiagnostics-color=always -O2 -pipe -march=znver3 -fstack-protector-strong -fno-strict-aliasing   -DNDEBUG -std=gnu++20 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -fPIC -pthread -MD -MT kcms/libkwindevices/CMakeFiles/kwindevices.dir/kwindevices_autogen/mocs_compilation.cpp.o -MF kcms/libkwindevices/CMakeFiles/kwindevices.dir/kwindevices_autogen/mocs_compilation.cpp.o.d -o kcms/libkwindevices/CMakeFiles/kwindevices.dir/kwindevices_autogen/mocs_compilation.cpp.o -c /usr/ports/x11/plasma6-plasma-desktop/work/.build/kcms/libkwindevices/kwindevices_autogen/mocs_compilation.cpp
In file included from /usr/ports/x11/plasma6-plasma-desktop/work/.build/kcms/libkwindevices/kwindevices_autogen/mocs_compilation.cpp:3:
In file included from /usr/ports/x11/plasma6-plasma-desktop/work/.build/kcms/libkwindevices/kwindevices_autogen/EWIEGA46WW/moc_inputdevice.cpp:9:
/usr/ports/x11/plasma6-plasma-desktop/work/.build/kcms/libkwindevices/kwindevices_autogen/EWIEGA46WW/../../../../../plasma-desktop-6.1.2/kcms/libkwindevices/inputdevice.h:171:19: error: reference to non-static member function must be called
  171 |             set(p.value);
      |                 ~~^~~~~
1 error generated.
ninja: build stopped: subcommand failed.
*** Error code 1

Stop.
make: stopped making "build" in /usr/ports/x11/plasma6-plasma-desktop

The following upstream commit fixes the build.

https://github.com/KDE/plasma-desktop/commit/02726a1ca0189f71f46513078cbc82af9daa9425
Comment 1 Jung-uk Kim freebsd_committer freebsd_triage 2024-10-25 10:15:27 UTC
It seems x11/plasma5-plasma-desktop has the same issue.

https://mail.kde.org/pipermail/kde-freebsd/2024-October/043069.html
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-10-26 05:44:10 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5a5cf2919de9fcc3baa1634acccb15164b7c27dd

commit 5a5cf2919de9fcc3baa1634acccb15164b7c27dd
Author:     Jason E. Hale <jhale@FreeBSD.org>
AuthorDate: 2024-10-26 05:27:29 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2024-10-26 05:43:29 +0000

    x11/plasma5-plasma-desktop: Fix build with LLVM 19

    PR:             282319
    Reported by:    jkim, pkg-fallout
    MFH:            2024Q4

 x11/plasma5-plasma-desktop/Makefile | 3 +++
 x11/plasma5-plasma-desktop/distinfo | 4 +++-
 2 files changed, 6 insertions(+), 1 deletion(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-10-26 05:44:11 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9b6bab9a1896e2a758f0ac1997d596d7a4d167a4

commit 9b6bab9a1896e2a758f0ac1997d596d7a4d167a4
Author:     Jason E. Hale <jhale@FreeBSD.org>
AuthorDate: 2024-10-26 05:39:20 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2024-10-26 05:43:29 +0000

    x11/plasma6-plasma-desktop: Fix build with LLVM 19

    While here:
    Fix MAINTAINER/COMMENT order

    PR:             282319
    Reported by:    jkim, pkg-fallout
    MFH:            2024Q4

 x11/plasma6-plasma-desktop/Makefile | 5 ++++-
 x11/plasma6-plasma-desktop/distinfo | 4 +++-
 2 files changed, 7 insertions(+), 2 deletions(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-10-26 05:46:12 UTC
A commit in branch 2024Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=acc062a3aa89f917b7e293045a46d4286f772f93

commit acc062a3aa89f917b7e293045a46d4286f772f93
Author:     Jason E. Hale <jhale@FreeBSD.org>
AuthorDate: 2024-10-26 05:27:29 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2024-10-26 05:44:30 +0000

    x11/plasma5-plasma-desktop: Fix build with LLVM 19

    PR:             282319
    Reported by:    jkim, pkg-fallout
    MFH:            2024Q4

    (cherry picked from commit 5a5cf2919de9fcc3baa1634acccb15164b7c27dd)

 x11/plasma5-plasma-desktop/Makefile | 3 +++
 x11/plasma5-plasma-desktop/distinfo | 4 +++-
 2 files changed, 6 insertions(+), 1 deletion(-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-10-26 05:46:13 UTC
A commit in branch 2024Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=23bc2b42397462c9a3a059c8d77223cf4710393a

commit 23bc2b42397462c9a3a059c8d77223cf4710393a
Author:     Jason E. Hale <jhale@FreeBSD.org>
AuthorDate: 2024-10-26 05:39:20 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2024-10-26 05:45:05 +0000

    x11/plasma6-plasma-desktop: Fix build with LLVM 19

    While here:
    Fix MAINTAINER/COMMENT order

    PR:             282319
    Reported by:    jkim, pkg-fallout
    MFH:            2024Q4

    (cherry picked from commit 9b6bab9a1896e2a758f0ac1997d596d7a4d167a4)

 x11/plasma6-plasma-desktop/Makefile | 5 ++++-
 x11/plasma6-plasma-desktop/distinfo | 4 +++-
 2 files changed, 7 insertions(+), 2 deletions(-)
Comment 6 Jason E. Hale freebsd_committer freebsd_triage 2024-10-26 05:59:12 UTC
Thanks for the patch, but I went with kde@'s usual approach of downloading the change from the upstream repo whenever possible.