Bug 282347 - mail/thunderbird: fix build with clang 19
Summary: mail/thunderbird: fix build with clang 19
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Christoph Moench-Tegeder
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-27 06:54 UTC by Jung-uk Kim
Modified: 2024-10-27 16:26 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (gecko)

Attachments
Fix build with clang 19 (8.70 KB, patch)
2024-10-27 06:54 UTC, Jung-uk Kim 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jung-uk Kim freebsd_committer freebsd_triage 2024-10-27 06:54:27 UTC 
Created attachment 254553 [details]
Fix build with clang 19

mail/thunderbird fails to build with clang 19 something like this:

https://lists.freebsd.org/archives/freebsd-ports/2024-October/006802.html
https://github.com/rnpgp/sexpp/issues/51

It can be fixed with the following third-party library patches:

https://github.com/rnpgp/rnp/commit/20419f739f632fb30666650544f0055e8d4f1afa
https://github.com/rnpgp/sexpp/commit/46744a14ffc235330bb99cebfaf294829c31bba4

Note security/rnp should have the same problem.
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-10-27 16:23:04 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=74e2551e863ba50a34faeeec03b82a078e8cb8e2

commit 74e2551e863ba50a34faeeec03b82a078e8cb8e2
Author:     Christoph Moench-Tegeder <cmt@FreeBSD.org>
AuthorDate: 2024-10-27 16:20:12 +0000
Commit:     Christoph Moench-Tegeder <cmt@FreeBSD.org>
CommitDate: 2024-10-27 16:20:12 +0000

    mail/thunderbird: fix build with clang 19

    clang/libcxx 19 is more strict about std::char_traits, causing build
    failure in the rnp submodule. Import patches from upstream (rnp).

    PR:             282347
    Submitted by:   jkim@

 mail/thunderbird/files/patch-rnp-clang19 (new) | 200 +++++++++++++++++++++++++
 1 file changed, 200 insertions(+)
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-10-27 16:24:06 UTC 
A commit in branch 2024Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=cb327445deda2390c38062262c8c4d0cd46829c2

commit cb327445deda2390c38062262c8c4d0cd46829c2
Author:     Christoph Moench-Tegeder <cmt@FreeBSD.org>
AuthorDate: 2024-10-27 16:20:12 +0000
Commit:     Christoph Moench-Tegeder <cmt@FreeBSD.org>
CommitDate: 2024-10-27 16:23:23 +0000

    mail/thunderbird: fix build with clang 19

    clang/libcxx 19 is more strict about std::char_traits, causing build
    failure in the rnp submodule. Import patches from upstream (rnp).

    PR:             282347
    Submitted by:   jkim@

    (cherry picked from commit 74e2551e863ba50a34faeeec03b82a078e8cb8e2)

 mail/thunderbird/files/patch-rnp-clang19 (new) | 200 +++++++++++++++++++++++++
 1 file changed, 200 insertions(+)
Comment 3 Christoph Moench-Tegeder freebsd_committer freebsd_triage 2024-10-27 16:26:52 UTC 
I try to keep most patches organized by topic, else it's a PITA down the line when I have to rebase/adapt/update.