Bug 282349 - sysutils/fusefs-squashfuse: Improve port
Summary: sysutils/fusefs-squashfuse: Improve port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-27 08:44 UTC by Daniel Engberg
Modified: 2024-10-27 22:38 UTC (History)
1 user (show)

See Also:
jsmith: maintainer-feedback+


Attachments
Patch for fusefs-squashfuse (1.93 KB, patch)
2024-10-27 08:44 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-10-27 08:44:16 UTC
Created attachment 254556 [details]
Patch for fusefs-squashfuse

* Switch from PORTVERSION to DISTVERSION
* Use USES= fuse:3 helper
* Define dependency for liblzo2, liblz4 and libzstd
* Remove GNU_CONFIGURE_MANPREFIX
* Don't build static libs
* Set pkgconfigdir

Compile tested on FreeBSD 14.1-RELEASE (amd64) (make, make check-plist)

Poudriere testport OK 13.3-RELEASE (amd64)
Poudriere testport OK 14.1-RELEASE (amd64)
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2024-10-27 08:45:37 UTC
..and I forgot, remove USES= autoreconf
Comment 2 Jesse Smith 2024-10-27 22:05:30 UTC
Patch not only looks good to me, it clears up the build issues I had with the upgrade to 0.5.2 on FreeBSD 13.4. Let's go ahead and commit this change.
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-10-27 22:37:56 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=eb9483669a70bc39c2bbbe64c98a16179f385b85

commit eb9483669a70bc39c2bbbe64c98a16179f385b85
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-10-27 22:34:52 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-10-27 22:34:56 +0000

    sysutils/fusefs-squashfuse: Improve port

    * Switch from PORTVERSION to DISTVERSION
    * Use USES= fuse:3 helper
    * Remove USES= autoreconf
    * Define dependency for liblzo2, liblz4 and libzstd
    * Remove GNU_CONFIGURE_MANPREFIX
    * Don't build static libs
    * Set pkgconfigdir

    PR:             282349
    Reviewed by:    Jesse Smith <jsmith@resonatingmedia.com> (maintainer)

 sysutils/fusefs-squashfuse/Makefile  | 13 +++++++++----
 sysutils/fusefs-squashfuse/distinfo  |  2 +-
 sysutils/fusefs-squashfuse/pkg-plist |  2 --
 3 files changed, 10 insertions(+), 7 deletions(-)
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2024-10-27 22:38:32 UTC
Committed, thanks