Bug 282391 - www/chromium: fix build with clang 19
Summary: www/chromium: fix build with clang 19
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-chromium (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-28 20:52 UTC by Jung-uk Kim
Modified: 2024-11-02 08:18 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (chromium)

Attachments
Fix build with clang 19 (1.23 KB, patch)
2024-10-28 20:52 UTC, Jung-uk Kim 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jung-uk Kim freebsd_committer freebsd_triage 2024-10-28 20:52:27 UTC 
Created attachment 254603 [details]
Fix build with clang 19

Although LLVM_DEFAULT is overridden with 18, I wanted to check whether it builds with clang 19.  In fact, it only needed the attached simple patch to fix the build.  Note it should not affect clang 18, at least in theory. :-)
Comment 1 Jung-uk Kim freebsd_committer freebsd_triage 2024-10-29 04:30:06 UTC 
FYI, I built it with clang 18 to make sure and it was successfully built without a problem.
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-11-02 08:16:21 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a1cf2e43d8e66ae4b3a2c227393beff9fef31f0d

commit a1cf2e43d8e66ae4b3a2c227393beff9fef31f0d
Author:     Robert Nagy <rnagy@FreeBSD.org>
AuthorDate: 2024-11-02 08:12:56 +0000
Commit:     Robert Nagy <rnagy@FreeBSD.org>
CommitDate: 2024-11-02 08:15:17 +0000

    www/chromium: update to 130.0.6723.91

    Security:       https://vuxml.freebsd.org/freebsd/e17384ef-c5e8-4b5d-bb62-c13405e7f1f7.html
    PR:             282391

 www/chromium/Makefile                                      |  2 +-
 www/chromium/distinfo                                      | 14 +++++++-------
 .../patch-chrome_browser_sessions_session__restore.cc      |  6 ++++--
 www/chromium/files/patch-chrome_browser_ui_ui__features.cc |  8 +++++---
 www/chromium/files/patch-chrome_browser_ui_ui__features.h  |  8 +++++---
 ...dia__router_common_providers_cast_channel_enum__table.h |  9 +++++----
 6 files changed, 27 insertions(+), 20 deletions(-)