Bug 282392 - games/freeciv21: Fix build with clang 19
Summary: games/freeciv21: Fix build with clang 19
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-28 21:33 UTC by Tobias Rehbein
Modified: 2024-10-29 22:36 UTC (History)
1 user (show)

See Also:
vvd: merge-quarterly+

Attachments
Patch that fixes the build with clang 19 (1.81 KB, patch)
2024-10-28 21:33 UTC, Tobias Rehbein 		tobias.rehbein: maintainer-approval+
Details | Diff
Patch that fixes the build with clang 19, this time without PORTREVISION bump (1.70 KB, patch)
2024-10-29 21:26 UTC, Tobias Rehbein 		tobias.rehbein: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Rehbein 2024-10-28 21:33:35 UTC 
Created attachment 254605 [details]
Patch that fixes the build with clang 19

Apply a patch from upstream, that fixes the build with clang 19. This fixes pkg-fallout on 15.0-CURRENT.

poudriere testport: 14.1-RELEASE-p5 ok; 15.0-CURRENT ok
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2024-10-29 16:10:24 UTC 
If this patch doesn't change anything else, then why PORTREVISION bump?
Comment 2 Tobias Rehbein 2024-10-29 21:26:41 UTC 
Created attachment 254625 [details]
Patch that fixes the build with clang 19, this time without PORTREVISION bump

You are absolutely right, there is no reason to bumb PORTREVISION. I updated the patch accordingly.
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-10-29 22:32:30 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=133c2f7586601bb744c17b152029dbbd9af05d30

commit 133c2f7586601bb744c17b152029dbbd9af05d30
Author:     Tobias Rehbein <tobias.rehbein@web.de>
AuthorDate: 2024-10-29 22:31:20 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-10-29 22:31:20 +0000

    games/freeciv21: Fix build with clang 19

    Apply a patch from upstream, that fixes the build with clang 19.
    This fixes pkg-fallout on 15.0-CURRENT.

    PR:     282392
    MFH:    2024Q4

 games/freeciv21/Makefile | 3 ++-
 games/freeciv21/distinfo | 4 +++-
 2 files changed, 5 insertions(+), 2 deletions(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-10-29 22:33:31 UTC 
A commit in branch 2024Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9ccd3b44c588465f575b8a2a297027458628d49e

commit 9ccd3b44c588465f575b8a2a297027458628d49e
Author:     Tobias Rehbein <tobias.rehbein@web.de>
AuthorDate: 2024-10-29 22:31:20 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-10-29 22:32:57 +0000

    games/freeciv21: Fix build with clang 19

    Apply a patch from upstream, that fixes the build with clang 19.
    This fixes pkg-fallout on 15.0-CURRENT.

    PR:     282392
    MFH:    2024Q4
    (cherry picked from commit 133c2f7586601bb744c17b152029dbbd9af05d30)

 games/freeciv21/Makefile | 3 ++-
 games/freeciv21/distinfo | 4 +++-
 2 files changed, 5 insertions(+), 2 deletions(-)
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2024-10-29 22:36:41 UTC 
Thanks.