Bug 282498 - devel/py-parallax: GH_TAG does nothing
Summary: devel/py-parallax: GH_TAG does nothing
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Craig Leres
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-11-02 18:12 UTC by Craig Leres
Modified: 2025-01-15 20:35 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (egypcio)

Attachments
patch (327 bytes, patch)
2024-11-02 21:00 UTC, Craig Leres 		leres: maintainer-approval? (egypcio)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Craig Leres freebsd_committer freebsd_triage 2024-11-02 18:12:57 UTC 
The makefile for this port sets GH_TAG which doesn't do anything. It was likely meant to be GH_TAGNAME but the github hash specified corresponds to PORTVERSION which is the default and so redundant. Also, I believe GH_PROJECT defaults to PORTNAME and does not need to be set either in this circumstance.

Note: I am not a user of this port, I just happened to notice this while grep'ing port makefiles to figure out how to do something...
Comment 1 Craig Leres freebsd_committer freebsd_triage 2024-11-02 21:00:41 UTC 
Created attachment 254887 [details]
patch

Here's a quick patch, it builds and installs.
Comment 2 commit-hook freebsd_committer freebsd_triage 2025-01-15 20:35:08 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d63cba0578f1e7f1e5481b18200e6c809b49fc68

commit d63cba0578f1e7f1e5481b18200e6c809b49fc68
Author:     Craig Leres <leres@FreeBSD.org>
AuthorDate: 2025-01-15 20:34:02 +0000
Commit:     Craig Leres <leres@FreeBSD.org>
CommitDate: 2025-01-15 20:34:02 +0000

    devel/py-parallax: Remove useless GH_TAG and redundent GH_PROJECT

    GH_TAG doesn't do anything, remove it.

    GH_PROJECT already defaults to PORTNAME, remove it.

    PR:             282498
    Approved by:    egypcio (maintainer timeout, 2 months)

 devel/py-parallax/Makefile | 2 --
 1 file changed, 2 deletions(-)