Bug 282601 - security/libssh: Add OPTIONS for other Kerberos implementations
Summary: security/libssh: Add OPTIONS for other Kerberos implementations
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mateusz Piotrowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-11-07 10:31 UTC by Mateusz Piotrowski
Modified: 2025-01-30 18:05 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)


Attachments
Addition of Kerberos options (1.72 KB, patch)
2024-11-14 15:52 UTC, Mateusz Piotrowski
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mateusz Piotrowski freebsd_committer freebsd_triage 2024-11-07 10:31:38 UTC
I've run into an issue where bird2 would not start, because it depends on libssh which depends on the Kerberos in base. I use MIT Kerberos from ports, however.

I'll send a patch soon that adds support for other Kerberos implementations to security/libssh.
Comment 1 Mateusz Piotrowski freebsd_committer freebsd_triage 2024-11-14 15:52:38 UTC
Created attachment 255172 [details]
Addition of Kerberos options

I'm attaching the patch that adds support for the Kerberos options.

I'm still testing though. I'll let you know about the results of my testing soon.
Comment 2 Mateusz Piotrowski freebsd_committer freebsd_triage 2024-12-04 12:44:07 UTC
Hey, the tests were successful and I confirm that the patch works as intended. It's ready to be merged.
Comment 3 Po-Chuan Hsieh freebsd_committer freebsd_triage 2024-12-22 20:07:01 UTC
(In reply to Mateusz Piotrowski from comment #2)

Sorry for the delay due to unexpected busy since late November.

I've made minor modification based on attachment 255172 [details]. Please try this [1].

[1] https://people.freebsd.org/~sunpoet/patch/security-libssh.txt
Comment 4 Mateusz Piotrowski freebsd_committer freebsd_triage 2025-01-06 14:54:53 UTC
We've tested your modified patch and it works as expected.

I believe that the patch is ready to be merged whenever you are ready.
Comment 5 commit-hook freebsd_committer freebsd_triage 2025-01-30 18:05:24 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=814fca7b52d84494926efb89ce89198df944946d

commit 814fca7b52d84494926efb89ce89198df944946d
Author:     Mateusz Piotrowski <0mp@FreeBSD.org>
AuthorDate: 2025-01-30 17:59:46 +0000
Commit:     Mateusz Piotrowski <0mp@FreeBSD.org>
CommitDate: 2025-01-30 18:04:43 +0000

    security/libssh: Add OPTIONS for other Kerberos implementations

    PR:             282601
    Reviewed by:    sunpoet
    Approved by:    maintainer timeout
    Sponsored by:   Klara, Inc.
    Co-authored-by: Po-Chuan Hsieh <sunpoet@FreeBSD.org>

 security/libssh/Makefile | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)
Comment 6 Mateusz Piotrowski freebsd_committer freebsd_triage 2025-01-30 18:05:43 UTC
Thank you!