Created attachment 255026 [details] Update to 1.2.8 Update sysutils/hammer2 to version 1.2.8.
Maintainer informed via mail
*** Bug 282630 has been marked as a duplicate of this bug. ***
I'll take this; email maintainer to make sure he knows. If no reply in two weeks we will, a) commit the patch, b) return the port to the pool (3 strikes you're out rule)
Sent maintainer an email. Closed the PR I submitted as a DUP of this one.
LGTM. Note that I'm the upstream, but not FreeBSD ports committer hence cannot push this.
(In reply to kusumi.tomohiro from comment #5) Please also indicate if you wish for your port to be moved to the filesystems category (bug #282628). Could it be that your bugzilla email address doesn't match the one in the ports tree? It seems like you don't get emails when bugs are filed against your ports. The port has MAINTAINER=tkusumi@netbsd.org, which is where emails will be sent when a bug is reported against the port. But here on Bugzilla you use a different address. Please check which address works and indicate that the MAINTAINER field shall be set to that address.
Sorry, operated on the wrong port.
(In reply to Robert Clausecker from comment #6) Yeah, I did email him, cc'd you.
Maintainer requests that the COMMENT be changed. Maybe he could comment here real quick with what the new COMMENT is supposed to be and give approval for the patch?
Take. Maintainer has indicated approval and wishes that COMMENT be changed to HAMMER2 file system for FreeBSD (experimental write support) See also bug #282628.
patch: Already acked in comment 5. COMMENT: LGTM
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=f04d7893e5b05a6d97af88b77bf1861e5d51ab87 commit f04d7893e5b05a6d97af88b77bf1861e5d51ab87 Author: Herbert J. Skuhra <herbert@gojira.at> AuthorDate: 2024-11-22 14:17:43 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2024-11-25 10:22:15 +0000 filesystems/hammer2: update to 1.2.8 - adjust COMMENT to reflect write capabilities Changelog: https://github.com/kusumi/freebsd_hammer2/blob/v1.2.8/CHANGES PR: 282629 Approved by: tkusumi@netbsd.org (maintainer) filesystems/hammer2/Makefile | 4 ++-- filesystems/hammer2/distinfo | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-)
Thank you for your contribution.
Would it be more appropriate to mention such features and limitations in pkg-descr instead of COMMENT? Either way, can we get pkg-descr updated to reflect that write support is experimental instead of not planned? Might be more helpful to mention that it is Dragonfly's native filesystem in addition to or in place of mentioning it is a port of it for FreeBSD (a redundant description that applies to many ports tree entries). Having a link to https://www.dragonflybsd.org/hammer/ or direct link to https://gitweb.dragonflybsd.org/dragonfly.git/blob/HEAD:/sys/vfs/hammer2/DESIGN would help users better understand the filesystem.