Bug 282641 - www/osrm-backend: Fix pkg-fallout on current after update to clang19
Summary: www/osrm-backend: Fix pkg-fallout on current after update to clang19
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-11-09 08:43 UTC by Peter Laursen
Modified: 2024-11-14 08:54 UTC (History)
1 user (show)

See Also:

Attachments
Patch to fix pkg-fallout on Current after clang19 was merged (483 bytes, patch)
2024-11-09 08:43 UTC, Peter Laursen 		freebsd: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Laursen 2024-11-09 08:43:25 UTC 
Created attachment 255046 [details]
Patch to fix pkg-fallout on Current after clang19 was merged

Hi,
After the base system compiler was updated to Clang 19, the port fails to build. (The specific bug is in its version of sol2 included in this port).
To fix this, I've added a patch that uses the default version of Clang on FreeBSD-Current after the update to clang 19 was applied.
It's a bit heavy-handed, but at least it gets the port building again on Current until I can find some time to make a more permanent fix for the library.

All the best,

Peter.
P.S.: Yes, I am the port maintainer for this port. I'm not quite sure what flags to set for this, so please guide me.
P.P.S.: I hope the patch does not mess up the formatting of the Makefile - it's a bit tricky with the current screen reader to check whether the file is formatted properly. I've run portfmt and portclippy on the Makefile, so hope that's good enough.
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2024-11-11 13:19:32 UTC 
Check if you can unbundle sol2 in the future.

OPTIONS_DEFINE cannot be set after .include <bsd.port.options.mk>.  Is the DEBUG option still needed?  I don't see it doing anything.

I'll fix this error on commit.
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-11-14 08:45:34 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=dd668bbfb7dc3e9255ba26347b7cc48106f70c0b

commit dd668bbfb7dc3e9255ba26347b7cc48106f70c0b
Author:     Peter Laursen <freebsd@mosedal.net>
AuthorDate: 2024-11-11 13:19:41 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2024-11-14 08:43:23 +0000

    www/osrm-backend: fix build post LLVM 19 import

    After the base system compiler was updated to Clang 19, the port failed
    to build. (The specific bug is in its version of sol2 included in this
    port).  To fix this, I've added a patch that uses an older version of
    Clang on FreeBSD-CURRENT after the update to clang 19 was applied.
    It's a bit heavy-handed, but at least it gets the port building again on
    CURRENT until I can find some time to make a more permanent fix for the
    library.

    PR:             282641

 www/osrm-backend/Makefile | 7 +++++++
 1 file changed, 7 insertions(+)
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2024-11-14 08:54:38 UTC 
Thank you for your contribution.