Bug 282657 - net-p2p/ncdc: update 1.22.1 → 1.24.1
Summary: net-p2p/ncdc: update 1.22.1 → 1.24.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL: https://dev.yorhel.nl/ncdc/changes
Keywords:
Depends on:
Blocks:
 
Reported: 2024-11-09 23:15 UTC by Älven
Modified: 2024-12-22 00:56 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (earl1k)

Attachments
[PATCH] net-p2p/ncdc: update 1.22.1 → 1.24.1 (2.46 KB, patch)
2024-11-09 23:15 UTC, Älven 		no flags Details | Diff
[PATCH] net-p2p/ncdc: update 1.22.1 → 1.24.1 (2.53 KB, patch)
2024-11-10 20:44 UTC, Älven 		no flags Details | Diff
Patch for ncdc (2.01 KB, patch)
2024-11-17 13:05 UTC, Daniel Engberg 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Älven 2024-11-09 23:15:17 UTC 
Created attachment 255059 [details]
[PATCH] net-p2p/ncdc: update 1.22.1 → 1.24.1
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2024-11-10 18:58:55 UTC 
CFLAGS and LDFLAGS can be replaced with USES= localbase:ldflags
Comment 2 Älven 2024-11-10 20:44:09 UTC 
Created attachment 255082 [details]
[PATCH] net-p2p/ncdc: update 1.22.1 → 1.24.1

(In reply to Daniel Engberg from comment #1)
Thanks! This helped. :)
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2024-11-17 13:05:38 UTC 
Created attachment 255234 [details]
Patch for ncdc

Improved patched based on the previously submitted one

* Remove a bunch of incorrect LIB_DEPENDS
* Remove gmake dependency
* Use sqlite helper
* Remove CONFIGURE_ENV entries (unnecessary except for ncurses on FreeBSD 13)

Compile tested on FreeBSD 13.4 (i386+amd64) and 14.1 (amd64)
Comment 4 Zsolt Udvari freebsd_committer freebsd_triage 2024-12-11 10:28:43 UTC 
Maintainer timeout.
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-12-21 23:08:37 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=48c1def2890dce7b52049fc151b168016433d05e

commit 48c1def2890dce7b52049fc151b168016433d05e
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-12-21 20:11:27 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-12-21 23:06:55 +0000

    net-p2p/ncdc: Update to 1.24.1

    * Rework and adjust list of library dependencies
    * Remove gmake dependency
    * Use sqlite helper
    * Remove CONFIGURE_ENV entries (unnecessary except for ncurses on FreeBSD 13)

    Previous iteration of patch submitted by Älven <alster@vinterdalen.se>

    PR:             282657
    Approved by:    portmgr (maintainer timeout, 1+ month)

 net-p2p/ncdc/Makefile | 30 +++++++++++++-----------------
 net-p2p/ncdc/distinfo |  6 +++---
 2 files changed, 16 insertions(+), 20 deletions(-)
Comment 6 Älven 2024-12-22 00:56:14 UTC 
Thanks!