Bug 282747 - mail/sendmail: add confBLACKLISTD option
Summary: mail/sendmail: add confBLACKLISTD option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dirk Meyer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-11-14 01:02 UTC by antonfb
Modified: 2024-11-15 07:57 UTC (History)
1 user (show)

See Also:
dinoex: maintainer-feedback+


Attachments
diff to cf/m4/proto.m4 (353 bytes, patch)
2024-11-14 01:02 UTC, antonfb
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description antonfb 2024-11-14 01:02:19 UTC
Created attachment 255156 [details]
diff to cf/m4/proto.m4

mail/sendmail has blacklistd support but it must be enabled by an option. It would be good to have a .mc option to enable this.
Patch suggested although it might be good to make this conditional on the port build option.
Comment 1 Dirk Meyer freebsd_committer freebsd_triage 2024-11-14 10:25:17 UTC
my prefered way to set UseBlacklist is by adding it to make.conf

sendmail_flags="-L sm-mta -bd -q30s -O UseBlacklist"

I will test for regressions.
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-11-14 15:02:21 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=19042fe3864739806d2d9d07637779c4c294b9dd

commit 19042fe3864739806d2d9d07637779c4c294b9dd
Author:     Dirk Meyer <dinoex@FreeBSD.org>
AuthorDate: 2024-11-14 15:01:41 +0000
Commit:     Dirk Meyer <dinoex@FreeBSD.org>
CommitDate: 2024-11-14 15:01:41 +0000

    mail/sendmail: add confBLACKLISTD option

    PR: 282747

 mail/sendmail/Makefile                         |  3 ++-
 mail/sendmail/files/extra-patch-proto.m4 (new) | 12 ++++++++++++
 2 files changed, 14 insertions(+), 1 deletion(-)
Comment 3 Dirk Meyer freebsd_committer freebsd_triage 2024-11-14 15:19:34 UTC
Looks fine.

No regression if used with rc.conf flags.

# diff new.cf sendmail.cf
< # Use Blacklistd
< #O UseBlacklist=false
Comment 4 Helge Oldach 2024-11-15 07:53:19 UTC
The behaviour implemented by this patch is not exactly intuitive: If a user selects the BLACKLISTD option in Makefile, s/he most likely wants to have it active when running sendmail. But then, why does the .mc option default to "false", actually? That is not exactly sensible. I'd say: either make it default "True", or document that the user still has to *manually* add define(`confBLACKLISTD', True) to the .mc file.
Comment 5 Helge Oldach 2024-11-15 07:57:56 UTC
(In reply to Helge Oldach from comment #4)
(That should read define(`confBLACKLIST', True) obviously. Bug subject misleading.)