Bug 282761 - science/geant4: Fix build error
Summary: science/geant4: Fix build error
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Nuno Teixeira
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-11-14 16:54 UTC by Erik Jensen
Modified: 2024-11-19 10:19 UTC (History)
1 user (show)

See Also:
eduardo: merge-quarterly+

Attachments
Port patch (1.15 KB, patch)
2024-11-14 16:54 UTC, Erik Jensen 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Jensen 2024-11-14 16:54:41 UTC 
Created attachment 255175 [details]
Port patch

The attached diff fixes build errors such as the one in this build log:
https://pkg-status.freebsd.org/beefy18/data/main-amd64-default/pea7acb655568_s65a4daeaf32/logs/geant4-11.2.2_2.log

Severity "Affects Some People" due to this simple error stealing CPU time from the FreeBSD pkg build servers
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2024-11-18 13:04:46 UTC 
-    ,m_branch(a_from.m_barnch)
+    ,m_branch(a_from.m_branch)

Is this a typo?
Are upstream aware of it?

I will try to take a look tomorrow.
Comment 2 Erik Jensen 2024-11-18 17:37:19 UTC 
Upstream are aware of it and will fix it in their next release.

Not all systems need to compile this specific piece of code, so the typo
has been there for quite some time...
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-11-19 08:29:14 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3f947d3a1d86212efcac3e1f4a53363ad4875f5f

commit 3f947d3a1d86212efcac3e1f4a53363ad4875f5f
Author:     Erik Jensen <erik@tenku.dk>
AuthorDate: 2024-11-19 08:14:16 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2024-11-19 08:27:12 +0000

    science/geant4: Fix build error

    Apply patch to fix typo in code builded in some systems that leads to build errors.
    This patch unbreaks build on main amd64, i386 and armv7.
    See also:  https://portsfallout.com/port/33546/

    PR:             282761
    MFH:            2024Q4

 science/geant4/Makefile                                       |  2 +-
 ...ce_externals_g4tools_include_tools_wroot_columns.icc (new) | 11 +++++++++++
 2 files changed, 12 insertions(+), 1 deletion(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-11-19 09:52:25 UTC 
A commit in branch 2024Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=75b54e539dd0899bd584584aabce4f0a5f6f2a76

commit 75b54e539dd0899bd584584aabce4f0a5f6f2a76
Author:     Erik Jensen <erik@tenku.dk>
AuthorDate: 2024-11-19 08:14:16 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2024-11-19 09:51:21 +0000

    science/geant4: Fix build error

    Apply patch to fix typo in code builded in some systems that leads to
    build errors.
    This patch unbreaks build on main amd64, i386 and armv7.
    See also:  https://portsfallout.com/port/33546/

    PR:             282761
    MFH:            2024Q4

    (cherry picked from commit 3f947d3a1d86212efcac3e1f4a53363ad4875f5f)

 science/geant4/Makefile                                       |  2 +-
 ...ce_externals_g4tools_include_tools_wroot_columns.icc (new) | 11 +++++++++++
 2 files changed, 12 insertions(+), 1 deletion(-)
Comment 5 Nuno Teixeira freebsd_committer freebsd_triage 2024-11-19 10:19:59 UTC 
Committed, thank you!