Created attachment 255196 [details] zrepl-dsh2dsh-0.9.1.patch Upgrading needs to modify configuration file: /usr/local/etc/zrepl/zrepl.yml Please read more about this change here: https://github.com/dsh2dsh/zrepl?tab=readme-ov-file#breaking-changes https://github.com/dsh2dsh/zrepl/releases/tag/v0.8.10 https://github.com/dsh2dsh/zrepl/releases/tag/v0.9.0 https://github.com/dsh2dsh/zrepl/releases/tag/v0.9.1
What is COPY supposed to do? The macro does not seem to be defined; I'll use INSTALL_DATA instead. I'll go ahead and add an entry to UPDATING when committing this patch.
(In reply to Robert Clausecker from comment #1) > What is COPY supposed to do? > The macro does not seem to be defined; I got it from the definition of INSTALL_DATA in bsd.port.mk: INSTALL_DATA= ${INSTALL} ${COPY} -m ${_SHAREMODE} That file should be installed with 0600 mode, instead of 0644, which INSTALL_DATA uses. That's why I don't use INSTALL_DATA for that case.
I understand. I'll address this by adding @sample(,,0600) %%ETCDIR%%/keys.yaml.sample to pkg-plist so the file is installed with the correct mode.
(In reply to Robert Clausecker from comment #3) > @sample(,,0600) %%ETCDIR%%/keys.yaml.sample Great! That's even better. Thanks.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=03e8423f08859e54d5ac1263b1ba8e0e2faff6d0 commit 03e8423f08859e54d5ac1263b1ba8e0e2faff6d0 Author: Denis Shaposhnikov <993498+dsh2dsh@users.noreply.github.com> AuthorDate: 2024-11-15 15:03:20 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2024-11-18 00:57:54 +0000 filesystems/zrepl-dsh2dsh: update to 0.9.1 Upgrading needs to modify configuration file: /usr/local/etc/zrepl/zrepl.yml Please read more about this change here: https://github.com/dsh2dsh/zrepl?tab=readme-ov-file#breaking-changes Changelogs: https://github.com/dsh2dsh/zrepl/releases/tag/v0.8.10 https://github.com/dsh2dsh/zrepl/releases/tag/v0.9.0 https://github.com/dsh2dsh/zrepl/releases/tag/v0.9.1 PR: 282784 UPDATING | 11 +++++++++++ filesystems/zrepl-dsh2dsh/Makefile | 6 ++++-- filesystems/zrepl-dsh2dsh/distinfo | 10 +++++----- filesystems/zrepl-dsh2dsh/files/pkg-message.in | 14 ++++++++++++-- filesystems/zrepl-dsh2dsh/pkg-plist | 4 ++-- 5 files changed, 34 insertions(+), 11 deletions(-)
Thank you for your contribution.