Created attachment 255202 [details] [PATCH] Upgrade sysutils/logwatch from 7.5.1 to 7.11 First of all: I am not that much an expert of FreeBSD's ports. I had to make the following modifications to Makefile: 1) logwatch-7.11 depends on "HTML::Entities" but FreeBSD ports provide "p5-HTML-HTML5-Entities", only thus I added a new RUN_DEPENDS to the Makefile and extended REINPLACE_CMD to modifiy logwatch.pl accordingly 2) in contrast to logwatch-7.5.1/defaults/logwatch.conf now all entries in logwatch-7.11/defaults/logwatch.conf are commented out thus I needed to modify the default tmpdir location by REINPLACE_CMD I adjusted pkg-plist: 1) w.r.t. extended functionality 2) I replaced "etc/logwatch" by "%%ETCDIR%%" "poudriere testport" compiles without any glitches. All of my services (dovecot, postfix, http) produce identical output, besides improvements regarding "Unmatched Entries" HTH and regards, Michael
This looks reasonable, thank you for providing the patch. I'll do some copy editing and if everything is fine, commit it with my next batch. The main thing that needs fixing is that all the static replacements need to be patch files. Note that /var/cache is the correct directory, /usr/local/var is not a thing. Is there a changelog for this update?
(In reply to Robert Clausecker from comment #1) Hi, thanks for taking this PR. Initially I hestitated from modifying too much because I am not the maintainer ;-) "The main thing that needs fixing is that all the static replacements need to be patch files." I do assume you refer to all REINPLACE_CMD replacements, correct? I am willing to provide all these patches, thus you wouldn't have the work to do. But I am currently traveling with limited internet access, but I could finalize patches starting Dec, 8th, including, /var/cache Please note that there are two patches from myself waiting upstream: https://sourceforge.net/projects/logwatch/ "Is there a changelog for this update?" Not to my knowledge, sorry.
(In reply to Michael Grimm from comment #2) Yes, the REINPLACE_CMD uses. I have already done the copy-editing, no need for you to do it again. Expect a commit early next week. With the maintainer being AWOL, could I interest you in taking over maintainership over this port?
(In reply to Robert Clausecker from comment #3) > With the maintainer being AWOL What is the meeáning of AWOL? ... Of Live? > could I interest you in taking over maintainership over this port? You can ;-) But: I do need some mentoring in the beginning. I do know https://docs.freebsd.org/en/books/porters-handbook/book/, though. What would be my address to seek mentoring, freebsd-ports@freebsd.org?
(In reply to Michael Grimm from comment #4) AWOL means “away without leave;” it's a military term. I'll add you as maintainer of the port. The best way to get help is probably to join the IRC channels of the ports team. Either #bsdports on EFnet or #freebsd-ports on libera.chat. You can of course also ask questions on the mailing list. Any patches you post will be reviewed before they are committed, but if you are unsure about how something is done, do not hesitate to point that out in the bug report. Looking forwards to more contributions from you!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=69240ce2a14de02145b7c62c018f22e80a18d674 commit 69240ce2a14de02145b7c62c018f22e80a18d674 Author: Michael Grimm <trashcan@ellael.org> AuthorDate: 2024-11-15 15:54:19 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2024-12-02 14:27:32 +0000 sysutils/logwatch: update to 7.11 - turn static REINPLACE_CMD into patch files - fix dependencies - submitter becomes maintainer PR: 282787 Approved by: trix@basement.net (maintainer timeout) sysutils/logwatch/Makefile | 17 +- sysutils/logwatch/distinfo | 6 +- sysutils/logwatch/files/Makefile | 5 + .../logwatch/files/patch-scripts_logwatch.pl (new) | 157 +++++++++++ sysutils/logwatch/pkg-plist | 309 +++++++++++---------- 5 files changed, 328 insertions(+), 166 deletions(-)
Thank you for your contribution.