Bug 282851 - math/gfan: fix build with clang 19
Summary: math/gfan: fix build with clang 19
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks: 280562
  Show dependency treegraph
 
Reported: 2024-11-18 17:11 UTC by Dimitry Andric
Modified: 2024-12-04 20:27 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (moritz)


Attachments
math/gfan: fix build with clang 19 (1.53 KB, patch)
2024-11-18 17:12 UTC, Dimitry Andric
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer freebsd_triage 2024-11-18 17:11:36 UTC
Clang 19 has become more strict about errors in member functions, which
results in errors building math/gfan:

  src/gfanlib_matrix.h:123:18: error: no member named 'vectormultiply' in 'Matrix<typ>'
    123 |         ret[i]=a.vectormultiply(b.column(i));
        |                ~ ^

The `vectormultiply` method has been commented out by upstream for
unknown reasons, but the `operator*` method that references it is also
never used, so stub it out.
Comment 1 Dimitry Andric freebsd_committer freebsd_triage 2024-11-18 17:12:50 UTC
Created attachment 255283 [details]
math/gfan: fix build with clang 19
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-12-04 20:23:49 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9020eeb540c2246c678a06098b916282e7251c11

commit 9020eeb540c2246c678a06098b916282e7251c11
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2024-11-18 12:43:25 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2024-12-04 20:22:19 +0000

    math/gfan: fix build with clang 19

    Clang 19 has become more strict about errors in member functions, which
    results in errors building math/gfan:

      src/gfanlib_matrix.h:123:18: error: no member named 'vectormultiply' in 'Matrix<typ>'
        123 |         ret[i]=a.vectormultiply(b.column(i));
            |                ~ ^

    The `vectormultiply` method has been commented out by upstream for
    unknown reasons, but the `operator*` method that references it is also
    never used, so stub it out.

    PR:             282851
    Approved by:    maintainer timeout (2 weeks)
    MFH:            2024Q4

 math/gfan/files/patch-src_gfanlib__matrix.h (new) | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-12-04 20:26:51 UTC
A commit in branch 2024Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2ec8449f67d4063267ae64a60b1ade3a6e5ddf7c

commit 2ec8449f67d4063267ae64a60b1ade3a6e5ddf7c
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2024-11-18 12:43:25 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2024-12-04 20:24:26 +0000

    math/gfan: fix build with clang 19

    Clang 19 has become more strict about errors in member functions, which
    results in errors building math/gfan:

      src/gfanlib_matrix.h:123:18: error: no member named 'vectormultiply' in 'Matrix<typ>'
        123 |         ret[i]=a.vectormultiply(b.column(i));
            |                ~ ^

    The `vectormultiply` method has been commented out by upstream for
    unknown reasons, but the `operator*` method that references it is also
    never used, so stub it out.

    PR:             282851
    Approved by:    maintainer timeout (2 weeks)
    MFH:            2024Q4

    (cherry picked from commit 9020eeb540c2246c678a06098b916282e7251c11)

 math/gfan/files/patch-src_gfanlib__matrix.h (new) | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)