Created attachment 255324 [details] fix function calls instead of using BOOST_FILESYSTEM_NO_DEPRECATED
Created attachment 255325 [details] patch-src_wallet_bdb.cpp fix function calls instead of using BOOST_FILESYSTEM_NO_DEPRECATED
Created attachment 255326 [details] patch-src_wallet_walletutil.cpp
Looks good to me
Looks goot to me
I was not able to set maintainer approval on the two patches, but only on the flags at the top, hopefully that is enough to approve this fix. Thanks you for the fix Adrian.
(In reply to Christopher Hall from comment #5) well, maybe I did something wrong. I just left the default (X) because none of those maintainer-flags labels made sense: "X", "+", "-", "?". It seems that I can edit the maintainer-flags on attachments, should I set to something else, like "? <your email address>" to request your approval (why isn't this the default if required, beats me)? The other flags really don't make sense from my perspective, unless default/none. Sorry for the trouble. Thank you, Adrian
according to this https://www.bugzilla.org/docs/2.18/html/flags-overview.html looks like you should set '?' to ask for approval then I can set '+' for accept or '-' for reject. It has been a long time since I used bugs, I did most previous updates via reviews, so I forgot how the flags work.
I don't believe per-attachment maintainer-feedback is needed unless I dim necessary for you to explicitly validate the code. The bug report already has a maintainer-feedback flag set which got your positive reply. So even though I flagged the attachments at first, I also reset them. Looking at some other bug reports closed with a resolution of 'FIXED', I think all you have to do is to change the bug report to 'Open' and wait for the commit hook to execute (none of them had per-attachment maintainer-feedback flag set). I can only change the state of the report to 'Closed', assignment which should rather be triggered by the commit hook's execution. Thank you, Adrian
I combined these patches with an update to 0.21.4 in review D47700
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=880b364108f5a935b6e62264a5b6a62428476d99 commit 880b364108f5a935b6e62264a5b6a62428476d99 Author: Christopher Hall <hsw@bitmark.com> AuthorDate: 2024-11-27 12:19:45 +0000 Commit: Gleb Popov <arrowd@FreeBSD.org> CommitDate: 2024-11-27 13:37:52 +0000 net-p2p/litecoin: Update to 0.21.4 and unbreak with recent Boost Signed-off-by: Christopher Hall <hsw@bitmark.com> Differential Revision: https://reviews.freebsd.org/D47700 PR: 282875 net-p2p/litecoin/Makefile | 6 ++---- net-p2p/litecoin/distinfo | 6 +++--- .../litecoin/files/patch-src_wallet_bdb.cpp (new) | 11 +++++++++++ .../files/patch-src_wallet_walletutil.cpp (new) | 20 ++++++++++++++++++++ 4 files changed, 36 insertions(+), 7 deletions(-)
Pushed, thanks everyone.