Created attachment 255392 [details] [PATCH] [NEW PORT] devel/lexbor: Modular web engine (HTML/CSS parser, renderer, ...)
Nice one! Main category should probably be www; secondary category of devel doesn't make much sense. Perhaps textproc or print if any at all. Are the utils not useful to the user? Why are they not installed by default? The plist does not include any utils or examples. What is the effect of the UTILS and EXAMPLES option then? Options that don't have any effect on the produced package don't need to be offered to the user. If there is a test suite, check if you can hook it up via USES=cmake:testing. Often, it makes sense to not have a TESTS option, but rather enable the test options in CMAKE_TESTING_ON.
Thank you for the advice on the ways to improve the patch. Options and their default values were taken directly as-is from upstream [0], some of them even being explicitly marked as experimental, other may be working the way I don't quite understand now, so I may and likely will just stick with the few ones I do know. I'm to rework it in a few days, when I hope to have few free hours. [0] https://lexbor.com/documentation/#linux-bsd-macos
Created attachment 255513 [details] [PATCH] [NEW PORT] www/lexbor: Modular web engine (HTML/CSS parser, renderer, ...)
Thank you for reworking this one. Seems to build fine. I just tried "make test" and it doesn't seem to run any tests. Please check that. Maybe the test suite isn't hooked into cmake?
Committed in ports ae4d160b5cafadf82f2a20a3c3686b89dffc25a4. Please check how the test suite is called (if any) and see if you can make test work in a future update.
Created attachment 255715 [details] [PATCH] www/lexbor: No need in CMAKE_TESTING_ON, test do run even without it Can't guess what could go wrong, as I have `make test` running all the tests even without CMAKE_TESTING_ON. If your experience is different we need the help of someone else with better knowledge of CMake.
Created attachment 255716 [details] Tests.log
Sorry, but I really can't fix it without a help. May be you may give some?
(In reply to Älven from comment #6) If I run "make all test" with the version of the port currently in the tree with or without your patch, I get: ===> Testing for lexbor-2.4.0 -- Project name: lexbor -- Build without Threads -- Lexbor version: 2.4.0 -- Looking for ceil -- Looking for ceil - not found -- Looking for ceil -- Looking for ceil - found -- Append module: core (1.8.0) -- Append module: css (1.2.0) -- Append module: dom (1.7.0) -- Append module: encoding (2.1.0) -- Append module: html (2.5.0) -- Append module: ns (1.2.0) -- Append module: punycode (1.1.0) -- Append module: selectors (0.3.0) -- Append module: tag (1.3.0) -- Append module: unicode (0.2.0) -- Append module: url (0.2.0) -- Append module: utils (0.3.0) -- CFLAGS: -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -O2 -Wall -pedantic -pipe -std=c99 -fPIC -- CXXFLAGS: -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -O2 -- Feature ASAN: disable -- Feature Fuzzer: disable -- Configuring done (0.2s) -- Generating done (0.0s) CMake Warning: Manually-specified variables were not used by the project: BUILD_TESTING -- Build files have been written to: /usr/home/fuz.ports/www/lexbor/work/.build ninja: no work to do. ninja: error: unknown target 'test', did you mean 'help'? *** Error code 1 Stop. make: stopped making "clean all test" in /usr/home/fuz.ports/www/lexbor
Created attachment 256368 [details] [PATCH] www/lexbor: fix building tests Seems like I have it done now. Could you, please, test it once again? Hope it should work for you too. 100% tests passed, 0 tests failed out of 119
Patch fixing building tests is on review
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=d21608467408d405d91a09ebec930ffcf29d09fe commit d21608467408d405d91a09ebec930ffcf29d09fe Author: Älven <alster@vinterdalen.se> AuthorDate: 2025-01-04 14:27:09 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2025-01-06 23:06:09 +0000 www/lexbor: hook up tests correctly PR: 282921 MFH: 2025Q1 www/lexbor/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
A commit in branch 2025Q1 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=8f7c25dc97f41dfce4183ca5f39681ae57fd658d commit 8f7c25dc97f41dfce4183ca5f39681ae57fd658d Author: Älven <alster@vinterdalen.se> AuthorDate: 2025-01-04 14:27:09 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2025-01-06 23:08:02 +0000 www/lexbor: hook up tests correctly PR: 282921 MFH: 2025Q1 (cherry picked from commit d21608467408d405d91a09ebec930ffcf29d09fe) www/lexbor/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Thank you for the update.