Bug 283044 - www/py-dj50-channels: Add new port for Channels built against Django 5
Summary: www/py-dj50-channels: Add new port for Channels built against Django 5
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kai Knoblich
URL:
Keywords:
Depends on:
Blocks: 283045
  Show dependency treegraph
 
Reported: 2024-11-29 20:53 UTC by James TD Smith
Modified: 2024-12-29 11:19 UTC (History)
2 users (show)

See Also:
kai: maintainer-feedback-
kai: merge-quarterly+


Attachments
Add www/py-dj50-channels port (2.15 KB, patch)
2024-11-29 20:53 UTC, James TD Smith
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James TD Smith 2024-11-29 20:53:37 UTC
Created attachment 255531 [details]
Add www/py-dj50-channels port

I was getting build failures for devel/py-dj50-strawberry-graphql, with the CHANNELS option enabled this adds www/py-channels as a dependency but that port in turn depends on Django 4 and the conflict causes the build to fail. 

To resolve the problem I copied the www/py-channels port to www/py-dj50-channels and changed the Django dependency to www/py-django50, patch for this is attached.
Comment 1 Kai Knoblich freebsd_committer freebsd_triage 2024-11-30 07:19:21 UTC
(In reply to James TD Smith from comment #0)

Hi James, thanks for the patch. I'll take care of this bug and bug #283045.  I connected both them here in Bugzilla as well.

Before I commit the patch, I would like to ask sunpoet@ whether he agrees to maintain another port.

Otherwise, it's no problem for me to be the maintainer of the new port www/py-dj50-channels.

@sunpoet: Is it OK for you to become maintainer of the new port www/py-dj50-channels as you already maintain www/py-channels?
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-12-14 16:57:56 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6e0d3b5fc73fd05df664b07c8b1ab3a8aa41c9e3

commit 6e0d3b5fc73fd05df664b07c8b1ab3a8aa41c9e3
Author:     James TD Smith <ahktenzero+freebsd@mohorovi.cc>
AuthorDate: 2024-12-14 16:51:20 +0000
Commit:     Kai Knoblich <kai@FreeBSD.org>
CommitDate: 2024-12-14 16:55:45 +0000

    www/py-dj50-channels: New port

    Channels augments Django to bring WebSocket, long-poll HTTP, task
    offloading and other async support to your code, using familiar Django
    design patterns and a flexible underlying framework that lets you not
    only customize behaviours but also write support for your own protocols
    and needs.

    Happy to pass this port to its maintainer who already maintain the
    Django 4.2 variant of it.

    Co-authored-by: Kai Knoblich <kai@FreeBSD.org>
    PR:             283044, 283045 [1]
    Reported by:    James TD Smith
    MFH:            2024Q4 (required to fix [1])

 www/Makefile                         |  1 +
 www/py-dj50-channels/Makefile (new)  | 27 +++++++++++++++++++++++++++
 www/py-dj50-channels/distinfo (new)  |  3 +++
 www/py-dj50-channels/pkg-descr (new) |  4 ++++
 4 files changed, 35 insertions(+)
Comment 3 Kai Knoblich freebsd_committer freebsd_triage 2024-12-14 17:08:10 UTC
(In reply to James TD Smith from comment #0)
(In reply to Kai Knoblich from comment #1)

There has been no feedback from sunpoet@, so I have now added myself as maintainer for the www/py-dj50-channels port.

I made a few trivial changes as well before committing the patch to the main branch:

- Pet portclippy (order of variables)
- Pet portlint (white space fix)

I"m going to merge the patch to the 2024Q4 branch.
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-12-15 11:04:22 UTC
A commit in branch 2024Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=311edf3c656730e185745743c0f51d64f30de3e4

commit 311edf3c656730e185745743c0f51d64f30de3e4
Author:     James TD Smith <ahktenzero+freebsd@mohorovi.cc>
AuthorDate: 2024-12-14 16:51:20 +0000
Commit:     Kai Knoblich <kai@FreeBSD.org>
CommitDate: 2024-12-15 10:14:24 +0000

    www/py-dj50-channels: New port

    Channels augments Django to bring WebSocket, long-poll HTTP, task
    offloading and other async support to your code, using familiar Django
    design patterns and a flexible underlying framework that lets you not
    only customize behaviours but also write support for your own protocols
    and needs.

    Happy to pass this port to its maintainer who already maintain the
    Django 4.2 variant of it.

    Co-authored-by: Kai Knoblich <kai@FreeBSD.org>
    PR:             283044, 283045 [1]
    Reported by:    James TD Smith
    MFH:            2024Q4 (required to fix [1])

    (cherry picked from commit 6e0d3b5fc73fd05df664b07c8b1ab3a8aa41c9e3)

 www/Makefile                         |  1 +
 www/py-dj50-channels/Makefile (new)  | 27 +++++++++++++++++++++++++++
 www/py-dj50-channels/distinfo (new)  |  3 +++
 www/py-dj50-channels/pkg-descr (new) |  4 ++++
 4 files changed, 35 insertions(+)
Comment 5 Kai Knoblich freebsd_committer freebsd_triage 2024-12-15 11:50:24 UTC
(In reply to James TD Smith from comment #0)

Committed to the main branch and MFH'ed into the 2024Q4 branch, all done.

Thanks for your report and patch!
Comment 6 Po-Chuan Hsieh freebsd_committer freebsd_triage 2024-12-22 19:47:19 UTC
(In reply to Kai Knoblich from comment #1)

Sorry for the delay due to unexpected busy since late November.

I assume it is better to maintain ports of django variants under same person. For ports maintained by me, please feel free to add new django variant without asking again. :)
Comment 7 Kai Knoblich freebsd_committer freebsd_triage 2024-12-29 11:19:59 UTC
(In reply to Po-Chuan Hsieh from comment #6)

No problem, and thank for the info. :) Roger that, I'll keep that in mind and will do so at the next opportunity.