Bug 283052 - sysutils/bareos-server: Update to 23.1.0 (including subports client and tray icon)
Summary: sysutils/bareos-server: Update to 23.1.0 (including subports client and tray ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jose Alonso Cardenas Marquez
URL:
Keywords:
Depends on:
Blocks: 278948
  Show dependency treegraph
 
Reported: 2024-11-30 16:41 UTC by Guido Falsi
Modified: 2024-12-02 20:20 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (acm)


Attachments
patch v1 (3.99 KB, patch)
2024-11-30 16:41 UTC, Guido Falsi
acm: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Guido Falsi freebsd_committer freebsd_triage 2024-11-30 16:41:10 UTC
Created attachment 255548 [details]
patch v1

Hi,

I've created an update for bareos ports to the latest version.

Tested on poudriere and using it in my own environment successfully.

Some notes:

- This update also fixes the build issues reported in bug #278948
- Fix rc script REQUIRE substitutions, remove unused %%REQ_MYSQL%%
- Do not install new sample dedup.conf file because it is invalid and causes the director to fail to start as is.

Can you approve or commit this update?

Thanks in advance!
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2024-11-30 16:43:02 UTC
I forgot to also explain, I patch the file BareosSetVariableDefaults.cmake because that's the only way I found to really stop it from installing python parts when the PYTHON option is disabled.
Comment 2 Jose Alonso Cardenas Marquez freebsd_committer freebsd_triage 2024-12-01 19:06:01 UTC
Comment on attachment 255548 [details]
patch v1

Approved
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-12-02 20:14:41 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=848e10ca6a87ad5520d4f130c24a44dd23301dd3

commit 848e10ca6a87ad5520d4f130c24a44dd23301dd3
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2024-12-02 20:12:52 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2024-12-02 20:12:52 +0000

    sysutils/bareos-server: Update to 23.1.0

    - Fix build on recent releases [1]
    - Fix rc script REQUIRE substitutions
    - Remove unused %%REQ_MYSQL%% in rc script
    - Do not install new sample dedup.conf file because it is invalid
      and causes the director to fail to start as is.

    PR:             283052, 278948 [1]
    Approved by:    acm (maintainer)

 sysutils/bareos-server/Makefile            | 14 ++++++++++----
 sysutils/bareos-server/distinfo            |  6 +++---
 sysutils/bareos-server/files/bareos-dir.in |  2 +-
 sysutils/bareos-server/pkg-plist           |  3 +++
 4 files changed, 17 insertions(+), 8 deletions(-)
Comment 4 Guido Falsi freebsd_committer freebsd_triage 2024-12-02 20:20:49 UTC
Update committed!

Thanks!