Bug 283148 - www/webtrees20: mark deprecated and set expiration_date
Summary: www/webtrees20: mark deprecated and set expiration_date
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Zsolt Udvari
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-05 20:13 UTC by Krzysztof
Modified: 2024-12-27 18:39 UTC (History)
1 user (show)

See Also:
ports: maintainer-feedback+


Attachments
patch to set expiration date (535 bytes, patch)
2024-12-05 20:13 UTC, Krzysztof
ports: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof 2024-12-05 20:13:55 UTC
Created attachment 255645 [details]
patch to set expiration date

www/webtrees20 should be set as deprecated because it depens on obsolete php version (php7x).

Also I suggest adding such entry to MOVED:
www/webtrees20|www/webtrees21|2023-12-31|Obsolete - use webtrees21 instead
Comment 1 Zsolt Udvari freebsd_committer freebsd_triage 2024-12-06 19:51:50 UTC
IMHO you should refactor the webtrees* ports.
As I see on web page (https://webtrees.net/install/) the webtrees21 branch is for php74-php82, the webtrees22 is for php83-php84.
I suggest php-flavors (https://docs.freebsd.org/en/books/porters-handbook/book/#flavors-auto-php-app) and using IGNORE_WITH_PHP (https://docs.freebsd.org/en/books/porters-handbook/book/#uses-php-ignore).

What do you think?
Comment 2 Krzysztof 2024-12-06 23:19:24 UTC
(In reply to Zsolt Udvari from comment #1)
Yes, you are right. I should add IGNORE_WITH_PHP

So I will make new patches.
Comment 3 Krzysztof 2024-12-09 11:18:51 UTC
OK, So I have "show stopper" :-)

currently (new) Makefile looks like this:
[...]

PKGNAMESUFFIX=  21 # (or 22 for new port)

[...]

WWWDIR=         ${PREFIX}/www/webtrees${PKGNAMESUFFIX}
DOCSDIR=        ${PREFIX}/share/doc/webtrees${PKGNAMESUFFIX}

with php-flavors it could be like this:

PKGNAMESUFFIX=  21${PHP_PKGNAMESUFFIX}

and how to "automate" these variables?

WWWDIR=         ${PREFIX}/www/webtrees${PKGNAMESUFFIX}
DOCSDIR=        ${PREFIX}/share/doc/webtrees${PKGNAMESUFFIX}

Maybe I can use/set VERSION_SUFFIX?

Maybe my question is very stupid, but I'm (still) begginer as port maintainer :-)))

Thanks a lot for any suggestions.
Comment 4 Krzysztof 2024-12-09 13:33:47 UTC
(In reply to Krzysztof from comment #3)
Maybe I can use "custom variables" in Makefile?
Comment 5 Zsolt Udvari freebsd_committer freebsd_triage 2024-12-09 16:26:07 UTC
(In reply to Krzysztof from comment #4)
You don't need use custom variables (only in rare cases).

You can see a similar example in devel/phpunit* ports.
The WWWDIR is /usr/local/www/phpunit/ without any suffix (can check with 'make -V WWWDIR'). Every phpunit* ports conflict another phpunit* ports so the /usr/local/www/phpunit/ directory is used only by one port.

If you've questions please ask!
Comment 6 Krzysztof 2024-12-10 07:47:58 UTC
(In reply to Zsolt Udvari from comment #5)

OK, thanks a lot for any hints.

I'm still thinking about howto avoid conflicts... As you can see there is such definition:
SUB_LIST=       VERSION_SUFFIX=${PKGNAMESUFFIX}

VERSION_SUFFIX variable is then "used" in pkg-message.in. I've made a grep across whole ports tree and I did not find explicite declaration, but maybe it will be correct to define in Makefile:

VERSION_SUFFIX=21
[...]

WWWDIR=         ${PREFIX}/www/webtrees${VERSION_SUFFIX}
SUB_LIST=       VERSION_SUFFIX=${VERSION_SUFFIX}
[...]

or new Makefile will look like current:
[...]
DOCSDIR=        ${PREFIX}/share/doc/webtrees21
Comment 7 Zsolt Udvari freebsd_committer freebsd_triage 2024-12-27 18:39:17 UTC
Sorry, I forgot to commit it. But now is committed, thanks!
Comment 8 commit-hook freebsd_committer freebsd_triage 2024-12-27 18:39:19 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0fdf2e8cbf13f3042f1c75552125cc59c769a658

commit 0fdf2e8cbf13f3042f1c75552125cc59c769a658
Author:     Krzysztof <ports@bsdserwis.com>
AuthorDate: 2024-12-27 18:38:10 +0000
Commit:     Zsolt Udvari <uzsolt@FreeBSD.org>
CommitDate: 2024-12-27 18:38:10 +0000

    www/webtrees20: Mark deprecated and set expiration_date

    PR:             283148
    Approved by:    submitter is maintainer

 www/webtrees20/Makefile | 3 +++
 1 file changed, 3 insertions(+)