Created attachment 255650 [details] poudriere testport log www/nginx-ultimate-bad-bot-blocker is updated every day because of "signatures" files. But during 4 years (previous version comes from 2020) it seems that executable files also changed (I've found some bugs duign using install-ngxblocker). So I think it is good idea to update this port. I've made an update patch. It was tested with poudriere - logfile is attached also.
Created attachment 255651 [details] update patch update patch is attached also
What kind of issued did you had with the install script? The only difference in the install script is adding /sbin to the path. The other change to scripts is to the update script, which seems sensible to add (but the email sending part just works on FreeBSD, so not that critical). The signature files are updated by the update script and are not even installed by the port (as the pkg-message explains), so there is no need to update the port every day.
(In reply to Alexander Leidinger from comment #2) It seems that I was misunderstood. I don't want to update port every day. I suggest that after 4 years it could be good idea to update the port. I suppose that current version (github one) will fix bug which is produced now. After run install-ngblocker in file /usr/local/etc/nginx/conf.d/globalblacklist.conf I have such paths: /usr/local/usr/local/usr/local/usr/local/usr/local/usr/local/usr/local/usr/local/etc/nginx/bots.d/blacklist-user-agents.conf I had to modify such path manually. That's why I think it is good idea to update. Also during this 4 years period tarball is much bigger. So maybe it is also good idea to get some more utils from tarball?
(In reply to Krzysztof from comment #3) The install script has only a change in PATH, nothing else. The update script has a change in the email sending part, nothing else. There are 3 scripts in total, the rest is config (also downloaded by the update script), so there is no new file in the tarball we would use (feel free to point out what I missed, I only had a quick look at the github content and have not identified something new which is not signature files related... which we let the update script handle). I agree that an update for the two changes could be done. My main point in my reply was to know about the issue you've seen. The issue you see I noticed too one time. While I don't remember what I did wrong at that time when I noticed it, I have some distant shadow of a memory that I may have done something wrong when I've seen that. The change of the path in the scripts will not change that. I have a look at getting some time to update the port in the next days.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=ec4007708a003cbb6e970eeac0236c36c0017f78 commit ec4007708a003cbb6e970eeac0236c36c0017f78 Author: Alexander Leidinger <netchild@FreeBSD.org> AuthorDate: 2024-12-11 09:46:45 +0000 Commit: Alexander Leidinger <netchild@FreeBSD.org> CommitDate: 2024-12-11 09:48:57 +0000 www/nginx-ultimate-bad-bot-blocker: Update to a recent version. Only small changes to the installed scripts. The data part is handled by the update script anyway. PR: 283151 www/nginx-ultimate-bad-bot-blocker/Makefile | 4 ++-- www/nginx-ultimate-bad-bot-blocker/distinfo | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-)