Bug 283169 - net/libfabric: fix build on armv7
Summary: net/libfabric: fix build on armv7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-06 23:29 UTC by Ronald Klop
Modified: 2024-12-15 12:44 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (yuri)


Attachments
git diff (731 bytes, patch)
2024-12-06 23:29 UTC, Ronald Klop
no flags Details | Diff
git diff (1.11 KB, patch)
2024-12-15 12:44 UTC, Ronald Klop
ronald: maintainer-approval? (yuri)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ronald Klop freebsd_committer freebsd_triage 2024-12-06 23:29:04 UTC
Created attachment 255677 [details]
git diff

The build on armv7 on FreeBSD 14 & 15 ends in configure because of missing rdma/rdma_cma.h headers.

https://lists.freebsd.org/archives/freebsd-pkg-fallout/2024-December/693892.html 

The attached patch makes the build succeed again by disabling the "verbs" provider.

This enables around 199 skipped ports at the official pkg builders for armv7.

NB: I have the rights to commit it myself. Can you take a look and see if this is a proper fix?
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2024-12-15 06:42:34 UTC
Committed, thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-12-15 06:43:45 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a0759227bb7df1171119c18839c434cd88f5f878

commit a0759227bb7df1171119c18839c434cd88f5f878
Author:     Ronald Klop <ronald@FreeBSD.org>
AuthorDate: 2024-12-15 06:41:58 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2024-12-15 06:41:58 +0000

    net/libfabric:  fix build on armv7

    PR:             283169

 net/libfabric/Makefile | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-12-15 06:43:46 UTC
A commit in branch 2024Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f6af381bd11cc7ffc691aa5e453ff877bf565e16

commit f6af381bd11cc7ffc691aa5e453ff877bf565e16
Author:     Ronald Klop <ronald@FreeBSD.org>
AuthorDate: 2024-12-15 06:41:58 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2024-12-15 06:43:08 +0000

    net/libfabric:  fix build on armv7

    PR:             283169
    (cherry picked from commit a0759227bb7df1171119c18839c434cd88f5f878)

 net/libfabric/Makefile | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)
Comment 4 Ronald Klop freebsd_committer freebsd_triage 2024-12-15 12:44:56 UTC
Created attachment 255874 [details]
git diff

Hi,

I noticed that the option VERBS is now disabled by default for all non-armv7 architectures also.
Maybe the attached patch is a better solution. (on top of the change that got into the ports tree)