Bug 283198 - games/openage: update to 0.6.0
Summary: games/openage: update to 0.6.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL: https://github.com/SFTtech/openage/re...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-08 12:39 UTC by Martin Filla
Modified: 2024-12-10 09:18 UTC (History)
1 user (show)

See Also:


Attachments
0001-openage-update-to-0.6.0.patch (10.19 KB, patch)
2024-12-08 12:39 UTC, Martin Filla
no flags Details | Diff
0001-openage-update-to-0.6.0.patch (10.66 KB, patch)
2024-12-09 20:46 UTC, Martin Filla
freebsd: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Filla 2024-12-08 12:39:49 UTC
Created attachment 255710 [details]
0001-openage-update-to-0.6.0.patch

Hi,
this is an update to 0.6.0. I tested in poudriere.
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2024-12-09 19:28:34 UTC
The build fails on i386 and armv7:

/wrkdirs/usr/ports/games/openage/work/openage-0.6.0/libopenage/pathfinding/integration_field.cpp:351:36: error: non-constant-expression cannot be narrowed from type 'long long' to 'unsigned int' in initializer list [-Wc++11-narrowing]
  351 |         this->integrate_cost(cost_field, {target_idx});
      |                                           ^~~~~~~~~~
/wrkdirs/usr/ports/games/openage/work/openage-0.6.0/libopenage/pathfinding/integration_field.cpp:351:36: note: insert an explicit cast to silence this issue
  351 |         this->integrate_cost(cost_field, {target_idx});
      |                                           ^~~~~~~~~~
      |                                           static_cast<unsigned int>( )
1 error generated.

Please check.  I can either mark the port as broken on these platforms or you can submit an updated patch to fix it.
Comment 2 Martin Filla 2024-12-09 20:46:39 UTC
Created attachment 255753 [details]
0001-openage-update-to-0.6.0.patch

I updated the Makefile for the broken platform.
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-12-10 09:07:41 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5d7c4f57aa8e0aa33b7319af2f3e19c91485e349

commit 5d7c4f57aa8e0aa33b7319af2f3e19c91485e349
Author:     Martin Filla <freebsd@sysctl.cz>
AuthorDate: 2024-12-08 12:37:16 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2024-12-10 09:02:57 +0000

    games/openage: update to 0.6.0

    Changelog: https://github.com/SFTtech/openage/releases/tag/v0.6.0

    PR:             283198

 games/openage/Makefile                             |  9 ++++-
 games/openage/distinfo                             |  6 +--
 ...tch-libopenage_pathfinding_pathfinder.cpp (new) | 11 ++++++
 games/openage/files/patch-openage_default__dirs.py |  4 +-
 games/openage/pkg-plist                            | 45 +++++++++++++++++++++-
 5 files changed, 66 insertions(+), 9 deletions(-)
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2024-12-10 09:18:35 UTC
Thank you for your contribution.