Bug 283211 - [maintainer-update] sysutils/minimunin to 0.6
Summary: [maintainer-update] sysutils/minimunin to 0.6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-08 22:52 UTC by Dirk Engling
Modified: 2024-12-10 09:15 UTC (History)
1 user (show)

See Also:


Attachments
Patch to bump minimunin to new version 0.6 (913 bytes, patch)
2024-12-08 22:52 UTC, Dirk Engling
no flags Details | Diff
Fixed patch to bump minimunin to new version 0.6 (1.07 KB, patch)
2024-12-09 11:22 UTC, Dirk Engling
erdgeist: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Engling 2024-12-08 22:52:29 UTC
Created attachment 255727 [details]
Patch to bump minimunin to new version 0.6

This updates minimunin to version 0.6.
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2024-12-09 11:12:52 UTC
Please set the maintainer-approved flag to "+" if you are the maintainer and submit a patch for one of your ports.  This sorts the patch into a special queue for already approved patches.

Will change PORTVERSION to DISTVERSION on commit as per policy.

Distinfo has wrong data about the distfile.  Did you reroll it?  It expects a distfile sized 8124 bytes, but it's actually just 4780 bytes.

Consider setting NO_ARCH=yes and NO_BUILD=yes if the port does not install architecture specific files and doesn't have a build step.

Please check these issues and resubmit.
Comment 2 Dirk Engling 2024-12-09 11:22:00 UTC
Created attachment 255735 [details]
Fixed patch to bump minimunin to new version 0.6

Corrected the old patch, because I rerolled the tar ball.

Also changed PORTVERSION to DISTVERSION and set the NO_ARCH and NO_BUILD flag, as per suggestion by committer.

Thanks.
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2024-12-09 11:46:44 UTC
Thanks, this looks good.
What user name shall I use for the commit?  You don't have one set on Bugzilla and there haven't been previous commits with your email address in the ports tree.
See you at congress!
Comment 4 Dirk Engling 2024-12-09 19:06:46 UTC
Interesting, I only now found the hidden setting to give myself a name. My account probably predates the time where that was mandatory.

erdgeist or Dirk Engling are both fine.

Thanks and see you at CCH
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2024-12-09 19:17:32 UTC
(In reply to Dirk Engling from comment #4)

It's not mandatory to set your name, but git wants me to put somoething there and I want to give you the chance to be attributed the way you want it instead of just making something up.

Will commit your patch with my next batch.
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-12-10 09:07:32 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d782bd62679144acd0bfa070a63b8dcc98d6554b

commit d782bd62679144acd0bfa070a63b8dcc98d6554b
Author:     Dirk Engling <erdgeist@erdgeist.org>
AuthorDate: 2024-12-09 11:44:14 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2024-12-10 09:03:00 +0000

    sysutils/minimunin: update to 0.6

     - set NO_ARCH, NO_BUILD

    Changelog: https://erdgeist.org/arts/software/minimunin/

    PR:             283211

 sysutils/minimunin/Makefile | 5 ++++-
 sysutils/minimunin/distinfo | 6 +++---
 2 files changed, 7 insertions(+), 4 deletions(-)
Comment 7 Robert Clausecker freebsd_committer freebsd_triage 2024-12-10 09:15:51 UTC
Thank you for your contribution.