Bug 283258 - */*: fix a few INSTALL_LIB static library invocations
Summary: */*: fix a few INSTALL_LIB static library invocations
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-11 15:03 UTC by Siva Mahadevan
Modified: 2024-12-17 01:06 UTC (History)
1 user (show)

See Also:

Attachments
[PATCH] */*: fix a few INSTALL_LIB static library invocations (3.49 KB, patch)
2024-12-11 15:03 UTC, Siva Mahadevan 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Siva Mahadevan 2024-12-11 15:03:02 UTC 
Created attachment 255779 [details]
[PATCH] */*: fix a few INSTALL_LIB static library invocations

Section 5.17.1 of the Porter's handbook states:
> Do not use INSTALL_LIB to install static libraries, because stripping them renders them useless. Use INSTALL_DATA instead.

This patch fixes the remaining few ports that wrongly use INSTALL_LIB to install static libraries.
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2024-12-11 15:14:52 UTC 
Thank you for finding this one.  This looks like a reasonable change.
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-12-17 00:59:55 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=dd628b45902c959f5de7aabd8b986923a7547508

commit dd628b45902c959f5de7aabd8b986923a7547508
Author:     Siva Mahadevan <me@svmhdvn.name>
AuthorDate: 2024-12-10 00:12:18 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2024-12-17 00:31:51 +0000

    */*: fix INSTALL_LIB static library invocations

    INSTALL_LIB must not be used to install static libraries as
    it strips the installed library; static libraries are useless
    when stripped.

    PR:             283258
    Approved by:    portmgr (infrastructure blanket)
    MFH:            2024Q4

 devel/asfml/Makefile       | 4 ++--
 devel/libwasmtime/Makefile | 4 ++--
 graphics/tachyon/Makefile  | 4 ++--
 net/quiche/Makefile        | 4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-12-17 01:02:58 UTC 
A commit in branch 2024Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=340847f86d2f839b0ba0eec6e049a10efee2fb6f

commit 340847f86d2f839b0ba0eec6e049a10efee2fb6f
Author:     Siva Mahadevan <me@svmhdvn.name>
AuthorDate: 2024-12-10 00:12:18 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2024-12-17 01:01:22 +0000

    */*: fix INSTALL_LIB static library invocations

    INSTALL_LIB must not be used to install static libraries as
    it strips the installed library; static libraries are useless
    when stripped.

    PR:             283258
    Approved by:    portmgr (infrastructure blanket)
    MFH:            2024Q4

    (cherry picked from commit dd628b45902c959f5de7aabd8b986923a7547508)

 devel/asfml/Makefile       | 4 ++--
 devel/libwasmtime/Makefile | 3 ++-
 graphics/tachyon/Makefile  | 4 ++--
 net/quiche/Makefile        | 4 ++--
 4 files changed, 8 insertions(+), 7 deletions(-)
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2024-12-17 01:06:55 UTC 
Thank you for your contribution.