Bug 283303 - audio/audacity: Upgrade audacity to 3.7.1
Summary: audio/audacity: Upgrade audacity to 3.7.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Charlie Li
URL: http://audacityteam.org
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-13 09:31 UTC by Jack
Modified: 2024-12-14 14:12 UTC (History)
2 users (show)

See Also:
xxjack12xx: maintainer-feedback+


Attachments
Patch to upgrade audacity to 3.7.1 (1.34 KB, patch)
2024-12-13 09:31 UTC, Jack
xxjack12xx: maintainer-approval+
Details | Diff
Upgrade to 3.7.1 and make soundtouch a hard dependency (3.24 KB, patch)
2024-12-13 19:04 UTC, Jack
xxjack12xx: maintainer-approval+
Details | Diff
Upgrade to audacity 3.7.1 with soundtouch requirement being needed. (1.85 KB, patch)
2024-12-13 23:37 UTC, Jack
xxjack12xx: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jack 2024-12-13 09:31:43 UTC
Created attachment 255834 [details]
Patch to upgrade audacity to 3.7.1

Patch to upgrade audacity to 3.7.1
Comment 1 Charlie Li freebsd_committer freebsd_triage 2024-12-13 14:04:13 UTC
The SOUNDTOUCH option needs to be unconditionally enabled for now (actually since 3.7.0): https://github.com/audacity/audacity/issues/7814
Comment 2 Jack 2024-12-13 19:04:29 UTC
Created attachment 255840 [details]
Upgrade to 3.7.1 and make soundtouch a hard dependency
Comment 3 Charlie Li freebsd_committer freebsd_triage 2024-12-13 22:46:17 UTC
Comment on attachment 255840 [details]
Upgrade to 3.7.1 and make soundtouch a hard dependency

Hmm, I wouldn't necessarily make it seem like this option is to never come back again? Since this is merely an upstream bug, maybe either comment out or EXCLUDE the option so you don't forget to surface it back when they fix it?
Comment 4 Jack 2024-12-13 22:59:04 UTC
(In reply to Charlie Li from comment #3)
Or maybe a better option is to mark it as BROKEN if soundtouch is not selected? Thoughts?
Comment 5 Charlie Li freebsd_committer freebsd_triage 2024-12-13 23:10:35 UTC
(In reply to Jack from comment #4)
SOUNDTOUCH_BROKEN_OFF is even better.
Comment 6 Jack 2024-12-13 23:37:32 UTC
Created attachment 255846 [details]
Upgrade to audacity 3.7.1 with soundtouch requirement being needed.
Comment 7 commit-hook freebsd_committer freebsd_triage 2024-12-14 14:10:27 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=99fefb026ee3bb43ebfb0c1fb585e6c0f487f41e

commit 99fefb026ee3bb43ebfb0c1fb585e6c0f487f41e
Author:     Jack <xxjack12xx@gmail.com>
AuthorDate: 2024-12-14 14:07:43 +0000
Commit:     Charlie Li <vishwin@FreeBSD.org>
CommitDate: 2024-12-14 14:07:43 +0000

    audio/audacity: update to 3.7.1

    Changelog: https://github.com/audacity/audacity/releases/tag/Audacity-3.7.1

    Note that SOUNDTOUCH disabled has been broken since 3.7.0: https://github.com/audacity/audacity/issues/7814

    PR: 283303

 audio/audacity/Makefile |  4 ++--
 audio/audacity/distinfo | 10 +++++-----
 2 files changed, 7 insertions(+), 7 deletions(-)
Comment 8 Charlie Li freebsd_committer freebsd_triage 2024-12-14 14:12:04 UTC
Committed, thanks!