Created attachment 255839 [details] update to 3.1.1 Release notes: https://gitlab.com/es-de/emulationstation-de/-/releases/v3.1.1
Long term, please check if you can unbundle the font files. We have many of them already packaged and it would be nice not to install the same file multiple times. You could e.g. RUN_DEPENDS on the font packages and then replace the files in the install with symbolic links to the dependencies.
(In reply to Robert Clausecker from comment #1) Thanks for the advice. I prepared a new patch with the suggestions. A post-install target does ${LN} -sf {LOCALBASE}/share/fonts/dejavu/DejaNuSans.ttf ${STAGEDIR}${DATADIR}/resources/fonts for the fonts. I used ${LN} -sf instead of ${RLN} because ${RLN} requires the fonts to be installed at build time. I could actually only replace three fonts from the list with fonts in the ports tree: DroidSansFallbackFull.ttf, DejaVuSans.ttf and Ubuntu-C.ttf. The other fonts are currently not to be found in the ports tree. Now I think your suggestion is a very good idea and guideline in the general case. But I would rather not do it for this port in this case. The space savings with symlinking the three fonts is marginal, the added post-install target adds complexity I need to maintain. I probably won't check constantly for the existence of the other fonts on every new release of es-de. But if you say it has to be done, then that's ok for me and I can submit the prepared patch.
(In reply to Stefan Schlosser from comment #2) Thanks for looking into it. We also have noto-emoji, but its font file got renamed (or perhaps it's not the same font? Not sure). That font file alone is ~10 MB. x11-fonts/freefont-ttf has FreeMono.ttf. For Nanum, we have korean/nanum-square, though the font file name is slightly different. Seems like it may not be the same font either. I'm asking you to unbundle the fonts because they are about 10% of the packages total size at currently ~7.8 MB. And note that DroidSans is already 3.0 MB of that, so even getting rid of just this one font is significant. So if we can deduplicate these, that would be quite helpful. As for the fonts we do not currently package, maybe we should look into packaging them. I'll leave this choice up to you. If you think this is too much of a hassle, then it's okay if you don't unbundle the fonts. > I probably won't check constantly for the existence of the other fonts on every new release of es-de. As the maintainer, I expect that you look into all changes that happen when the port is updated. Changes in the fonts are easy to see from the changed pkg-plist, so it doesn't seem like a hard thing to check for.
(In reply to Robert Clausecker from comment #3) Thanks for taking a deeper look into the available fonts, somehow I missed x11-fonts/freefont-ttf... I will look into it again and try to get more fonts into the patch. Will provide it in the next days. > As the maintainer, I expect that you look into all changes that happen when the > port is updated. Changes in the fonts are easy to see from the changed pkg-plist, > so it doesn't seem like a hard thing to check for. I articulated it the wrong way. Of course I check all the changes for new releases of ports I maintain and try to adapt the ports in the best way possible. I mean it the other way around, I probably won't check constantly if new changes in font ports are made and see if further fonts can be unbundled in emulators/es-de. Especially when the font filenames in the font ports are not matching with the expected filenames in es-de, which seems to be the case with korean/nanum-square.
(In reply to Stefan Schlosser from comment #4) That's reasonable and it's okay if you do the deduplication on a best-effort basis. As for the nanum fonts, I think those are actually different fonts than the one we package (they're "neo", ours are not). Let me know how you wish to proceed.
Created attachment 255889 [details] v2 I updated the patch to unbundle some fonts as suggested. In addition to the previously mentioned fonts I also used NotoColorEmoji.ttf from x11-fonts/noto-emoji for the expected NotoEmoji.ttf font. Both BUILD_DEPENDS and RUN_DEPENDS are required, or else the dependency on the fonts isn't registered in the package.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=78541fb98385e60af7d0a3218c8ad59d4d176792 commit 78541fb98385e60af7d0a3218c8ad59d4d176792 Author: Stefan Schlosser <bsdcode@disroot.org> AuthorDate: 2024-12-13 18:04:12 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2024-12-17 00:57:21 +0000 emulators/es-de: update to 3.1.1 - unbundle fonts Release notes: https://gitlab.com/es-de/emulationstation-de/-/releases/v3.1.1 PR: 283313 emulators/es-de/Makefile | 29 +++++++++++++++++++++++------ emulators/es-de/distinfo | 6 +++--- emulators/es-de/pkg-plist | 8 ++++++-- 3 files changed, 32 insertions(+), 11 deletions(-)
Thank you for your contribution.