Bug 283325 - graphics/glslang build failure
Summary: graphics/glslang build failure
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-14 08:16 UTC by jakub_lach
Modified: 2024-12-15 00:49 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jakub_lach 2024-12-14 08:16:27 UTC
FAILED: glslang/CMakeFiles/glslang.dir/__/SPIRV/SpvTools.cpp.o 
/usr/bin/c++ -DENABLE_HLSL -DENABLE_OPT=1 -DENABLE_SPIRV -DGLSLANG_OSINCLUDE_UNIX -I/usr/obj/usr/ports/graphics/glslang/work/glslang-15.1.0/glslang/.. -I/usr/obj/usr/ports/graphics/glslang/work/.build/include -I/usr/obj/usr/ports/graphics/glslang/work/glslang-15.1.0/glslang/../External -isystem /usr/local/include -O2 -pipe -march=penryn -fstack-protector-strong -fno-strict-aliasing -O2 -pipe -march=penryn -fstack-protector-strong -fno-strict-aliasing   -DNDEBUG -std=c++17 -fPIC -Wall -Wuninitialized -Wunused -Wunused-local-typedefs -Wimplicit-fallthrough -Wunused-parameter -Wunused-value -Wunused-variable -fno-rtti -fno-exceptions -pthread -Winvalid-pch -Xclang -include-pch -Xclang /usr/obj/usr/ports/graphics/glslang/work/.build/glslang/CMakeFiles/glslang.dir/cmake_pch.hxx.pch -Xclang -include -Xclang /usr/obj/usr/ports/graphics/glslang/work/.build/glslang/CMakeFiles/gl  slang.dir/cmake_pch.hxx -MD -MT glslang/CMakeFiles/glslang.dir/__/SPIRV/SpvTools.cpp.o -MF glslang/CMakeFiles/glslang.dir/__/SPIRV/SpvTools.cpp.o.d -o glslang/CMakeFiles/glslang.dir/__/SPIRV/SpvTools.cpp.o -c /usr/obj/usr/ports/graphics/glslang/work/glslang-15.1.0/SPIRV/SpvTools.cpp
/usr/obj/usr/ports/graphics/glslang/work/glslang-15.1.0/SPIRV/SpvTools.cpp:75:32: error: no member named 'SPV_ENV_VULKAN_1_4' in 'spv_target_env'
   75 |         return spv_target_env::SPV_ENV_VULKAN_1_4;
      |                ~~~~~~~~~~~~~~~~^
1 error generated.
[ 78% 54/69] /usr/bin/c++ -DENABLE_HLSL -DENABLE_OPT=1 -DENABLE_SPIRV -DGLSLANG_OSINCLUDE_UNIX -I/usr/obj/usr/ports/graphics/glslang/work/glslang-15.1.0/glslang/.. -I/usr/obj/usr/ports/graphics/glslang/work/.build/include -I/usr/obj/usr/ports/graphics/glslang/work/glslang-15.1.0/glslang/../External -isystem /usr/local/include -O2 -pipe -march=penryn -fstack-protector-strong -fno-strict-aliasing -O2 -pipe -march=penryn -fstack-protector-strong -fno-strict-aliasing   -DNDEBUG -std=c++17 -fPIC -Wall -Wuninitialized -Wunused -Wunused-local-typedefs -Wimplicit-fallthrough -Wunused-parameter -Wunused-value -Wunused-variable -fno-rtti -fno-exceptions -pthread -Winvalid-pch -Xclang -include-pch -Xclang /usr/obj/usr/ports/graphics/glslang/work/.build/glslang/CMakeFiles/glslang.dir/c  make_pch.hxx.pch -Xclang -include -Xclang /usr/obj/usr/ports/graphics/glslang/work/.build/glslang/CMakeFiles/glslang.dir/cmake_pch.hxx -MD -MT glslang/CMakeFiles/glslang.dir/__/SPIRV/SpvPostProcess.cpp.o -MF glslang/CMakeFiles/glslang.dir/__/SPIRV/SpvPostProcess.cpp.o.d -o glslang/CMakeFiles/glslang.dir/__/SPIRV/SpvPostProcess.cpp.o -c /usr/obj/usr/ports/graphics/glslang/work/glslang-15.1.0/SPIRV/SpvPostProcess.cpp
ninja: build stopped: subcommand failed.
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

FreeBSD 14.2-STABLE #0 stable/14-fe0506ce89 amd64
Comment 1 Ale 2024-12-14 08:56:01 UTC
Upgrading graphics/spirv-tools before graphics/glslang should fix that.
Missing dependency?
Comment 2 jakub_lach 2024-12-14 10:55:07 UTC
(In reply to Ale from comment #1)

Yes, I've thought the same after filing a PR - confirmed.
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-12-15 00:48:51 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=cbf133ac4b4a2f10bffbe11bcd2e5e048ea02628

commit cbf133ac4b4a2f10bffbe11bcd2e5e048ea02628
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2024-12-14 23:50:28 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2024-12-15 00:47:10 +0000

    graphics/glslang: track spirv-tools dependency after ffbcda74cb03

    https://github.com/KhronosGroup/glslang/commit/cd1f169c6a76
    https://github.com/KhronosGroup/glslang/commit/3805888a57c0

    PR:             283325

 graphics/glslang/Makefile | 2 ++
 1 file changed, 2 insertions(+)